Fix the --team option to accept the team name or id #76

Merged
merged 3 commits into from Nov 13, 2013

Conversation

Projects
None yet
3 participants
Contributor

enriquez commented Oct 9, 2013

  • Passing the --team option did not skip the "Select a team:" prompt.
  • The --team option should accept the name or id of the team.
  • Show the team id in the "Select a team:" prompt.
@enriquez enriquez Fix the --team option to accept the team name
Two issues were fixed here:
- Passing the --team option did not skip the "Select a team:" prompt.
- The --team option should accept the name of the team. Not the value of
  the radio button associated to the team.
9ece2e8

I'll second at least the part of this fix that removes always prompting for the team. There isn't a good way to script against the library if it prompts for teams every time it's run.

enriquez added some commits Oct 10, 2013

@enriquez enriquez Merge remote-tracking branch 'Joe030984/master' into fix_team_arg 4f207b6
@enriquez enriquez Let --team accept a team name or id
We can't rely on the team name to be unique, so we allow an id to be
specified. The id is printed along with the name in the list of options.
The beginning of the team name is still accepted.
6280a85
Contributor

enriquez commented Oct 10, 2013

There's a problem with uniquely identifying a team as shown in #78, so I've included that commit here and updated the --team flag to accept a name or id.

@mattt mattt added a commit that referenced this pull request Nov 13, 2013

@mattt mattt Merge pull request #76 from enriquez/fix_team_arg
Fix the --team option to accept the team name or id
905b3b8

@mattt mattt merged commit 905b3b8 into nomad:master Nov 13, 2013

Contributor

mattt commented Nov 13, 2013

Cool. Thanks again, @enriquez & @joe030984. Glad to have this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment