Skip to content

Golang bindings#534

Merged
AndriyMulyar merged 6 commits into
nomic-ai:mainfrom
go-skynet:main
May 15, 2023
Merged

Golang bindings#534
AndriyMulyar merged 6 commits into
nomic-ai:mainfrom
go-skynet:main

Conversation

@mudler
Copy link
Copy Markdown
Contributor

@mudler mudler commented May 11, 2023

This is a wrap up of what's currently used by https://github.com/go-skynet/LocalAI, I think this is far from perfect, but a good stab for a first implementation, and polish it in a second round. It is WIP yet as I'm still testing it and need to tidy it a bit, feedback is welcome

@AndriyMulyar
Copy link
Copy Markdown
Contributor

Please make sure to use the c bindings / api we have in gpt4all-backend!

@rguo123
Copy link
Copy Markdown
Contributor

rguo123 commented May 11, 2023

Amazing, thanks for the contribution! Can you also include a readme similar to this walking through how to build and install locally? Doesn't have to be long

@manyoso
Copy link
Copy Markdown
Collaborator

manyoso commented May 13, 2023

We need docs too like the python bindings. Are we getting close to merging this?

@mudler
Copy link
Copy Markdown
Contributor Author

mudler commented May 13, 2023

I'll try to put docs in place over the weekend!

@AndriyMulyar
Copy link
Copy Markdown
Contributor

When it comes to docs, i want to do the following:

  1. move the mkdocs build system to the root directory, currently its in the python bindings directory.
  2. docs.gpt4all.io should contain docs for all bindings (not solely python) and tutorials for use

@rguo123
Copy link
Copy Markdown
Contributor

rguo123 commented May 15, 2023

@AndriyMulyar @mudler
For this PR, let's just have golang specific docs ready? Think the larger docs refactor can be part of wiki/faq page changes. Lmk thoughts

@AndriyMulyar
Copy link
Copy Markdown
Contributor

This sounds good. The current documentation source is in the python bindings directory but I re-wrote it a bit to include future sections for other bindings. docs.gpt4all.io

@AndriyMulyar
Copy link
Copy Markdown
Contributor

@mudler what is blocking getting this merged?

@mudler mudler marked this pull request as ready for review May 15, 2023 14:24
@mudler
Copy link
Copy Markdown
Contributor Author

mudler commented May 15, 2023

all looks good here 👍 @AndriyMulyar

@AndriyMulyar AndriyMulyar merged commit 3f63cc6 into nomic-ai:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants