Accept signer address in ethers.getContractAt() and ethers.getContractFactory()
#1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` and `ethers.getContractAt`
…()` and `ethers.getContractAt()`
|
Hey @heri16, thanks for sending this. Unfortunately, we try not to merge new features that we haven't discussed first. Feel free to open an issue suggesting this change so we can see if it makes sense for us to include it. I know this is a very small change, but we are very picky about new features because each one adds complexity (i.e., potential bugs and things to document), so we err on the side of not adding new things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept signer address as string param to
hre.ethers.getContractAt()andhre.ethers.getContractFactory()