[feature] Add patternColoured Layout. #101

Merged
merged 1 commit into from Dec 2, 2012

Conversation

Projects
None yet
2 participants
Contributor

dignifiedquire commented Nov 22, 2012

Based on #90 this implements the possibillity to add the color codes
according to the log level via %[ and %].

Contributor

dignifiedquire commented Nov 23, 2012

I just realized that it's not working. Will open a new one when finished.

Owner

nomiddlename commented Nov 26, 2012

Thanks - good job I was too slow to merge it :)

Contributor

dignifiedquire commented Nov 26, 2012

I've fixed the problems. Should work now :)

Contributor

dignifiedquire commented Dec 2, 2012

@nomiddlename anything new?

Owner

nomiddlename commented Dec 2, 2012

Thanks for this - sorry for the delay, I've been at a conference for the last week. The only thing I'm concerned about in this is the duplication of patternLayout and its tests. Is there any reason why it needs to be a separate layout to patternLayout?

Contributor

dignifiedquire commented Dec 2, 2012

No problem. No not all, I just thought as there was concern about something like this that it might be better to keep those two separate. I can put them together if you want.

Owner

nomiddlename commented Dec 2, 2012

I think it'll be easier to maintain.

@dignifiedquire dignifiedquire [feature] Add color option to pattern layout.
Based on #90 this implements the possibillity to add the color codes
according to the log level via %[ and %].
4a7a90e
Contributor

dignifiedquire commented Dec 2, 2012

Done.

@nomiddlename nomiddlename pushed a commit that referenced this pull request Dec 2, 2012

Gareth Jones Merge pull request #101 from Dignifiedquire/feature-color-pattern
[feature] Add patternColoured Layout.
8b42e46

@nomiddlename nomiddlename merged commit 8b42e46 into nomiddlename:master Dec 2, 2012

1 check passed

default The Travis build passed
Details
Owner

nomiddlename commented Dec 2, 2012

Awesome. Merged, and published to npm - version 0.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment