Pass options from multiprocess appender to inner appender #116

Merged
merged 1 commit into from Feb 25, 2013

Projects

None yet

2 participants

@imkira
imkira commented Feb 20, 2013

If you use multiprocess with an inner appender (say 'file' type),
you are not able to pass options to the that inner appender.
For instance, in the example below cwd is not visible to 'file'.

log4js.configure({
    type: 'multiprocess',
    mode: 'master',
    appender: {
      type: 'file',
      ...
    }
  }, {
    cwd: 'whatever'
  });

This patch hopefully fixes that bug.

I would be happy if you could pull it into master.
Thank you in advance.

@nomiddlename nomiddlename merged commit 50eefcc into nomiddlename:master Feb 25, 2013

1 check failed

Details default The Travis build failed
@nomiddlename
Owner

Although the tests failed on travis, they passed when run on my machine. I suspect there's a timing problem in one of the tests. Thanks for the pull request!

@nomiddlename
Owner

Released in 0.5.7 in npm.

@imkira
imkira commented Feb 25, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment