Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 修复依赖注入 bot event 参数 union 校验失败 #1001

Merged
merged 1 commit into from
May 22, 2022

Conversation

yanyongyu
Copy link
Member

@yanyongyu yanyongyu commented May 22, 2022

fix #998

@yanyongyu yanyongyu added the bug Something isn't working label May 22, 2022
@yanyongyu yanyongyu requested a review from SK-415 May 22, 2022 04:33
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #1001 (f89bd08) into master (fe43cc9) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   77.45%   77.69%   +0.24%     
==========================================
  Files          42       42              
  Lines        3127     3134       +7     
==========================================
+ Hits         2422     2435      +13     
+ Misses        705      699       -6     
Flag Coverage Δ
unittests 77.69% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/internal/adapter/event.py 95.23% <100.00%> (+2.38%) ⬆️
nonebot/internal/params.py 97.61% <100.00%> (+1.86%) ⬆️
nonebot/utils.py 87.80% <100.00%> (+0.74%) ⬆️
nonebot/dependencies/__init__.py 89.36% <0.00%> (+1.06%) ⬆️
nonebot/dependencies/utils.py 89.28% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe43cc9...f89bd08. Read the comment docs.

@github-actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-1001--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 22, 2022 04:36 Inactive
@MingxuanGame
Copy link
Contributor

LGTM

@yanyongyu yanyongyu merged commit 6feed06 into master May 22, 2022
@yanyongyu yanyongyu deleted the fix/union-type branch May 22, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Bug: Union Checking Failed
3 participants