Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 优化依赖注入结构 #1227

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

yanyongyu
Copy link
Member

No description provided.

@yanyongyu yanyongyu added the enhancement New feature or request label Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1227 (63b8e64) into master (5114749) will increase coverage by 0.08%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   85.04%   85.13%   +0.08%     
==========================================
  Files          41       41              
  Lines        3230     3215      -15     
==========================================
- Hits         2747     2737      -10     
+ Misses        483      478       -5     
Flag Coverage Δ
unittests 85.13% <96.29%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/dependencies/__init__.py 94.38% <93.87%> (+4.16%) ⬆️
nonebot/internal/matcher.py 93.65% <100.00%> (-0.05%) ⬇️
nonebot/internal/params.py 98.70% <100.00%> (-0.08%) ⬇️
nonebot/rule.py 94.80% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

🚀 Deployed on https://deploy-preview-1227--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 5, 2022 07:36 Inactive
Copy link
Member

@synodriver synodriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大体上ok

@yanyongyu yanyongyu merged commit a0b186a into master Sep 7, 2022
@yanyongyu yanyongyu deleted the feat/update-dependent branch September 7, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants