Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 在加载 driver 引发 ImportError 时,使用 raise from e #1689

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

shoucandanghehe
Copy link
Contributor

close #1688

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1689 (007cfa0) into master (6d7435b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1689   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          44       44           
  Lines        3331     3331           
=======================================
  Hits         2879     2879           
  Misses        452      452           
Flag Coverage Δ
unittests 86.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/drivers/aiohttp.py 61.79% <ø> (ø)
nonebot/drivers/fastapi.py 88.66% <ø> (ø)
nonebot/drivers/httpx.py 91.66% <ø> (ø)
nonebot/drivers/quart.py 90.14% <ø> (ø)
nonebot/drivers/websockets.py 68.75% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

🚀 Deployed on https://deploy-preview-1689--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 8, 2023 15:22 Inactive
@yanyongyu yanyongyu added the enhancement New feature or request label Feb 8, 2023
@yanyongyu yanyongyu merged commit 4c0d406 into nonebot:master Feb 9, 2023
@shoucandanghehe shoucandanghehe deleted the use-raise-from-e branch February 9, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Feature: 在加载 drivers 引发 ImportError 时,使用 raise from e 而不是 raise from None
2 participants