Integration tests #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewismarshall
force-pushed
the
integration_tests
branch
10 times, most recently
from
7c05b9e
to
0b7dc33
Compare
lewismarshall
force-pushed
the
integration_tests
branch
3 times, most recently
from
da1a3c1
to
a66a5f3
Compare
vaijab
approved these changes
Jun 30, 2017
| @@ -16,6 +18,12 @@ pipeline: | |||
| - golint $(go list ./... | grep -v /vendor | grep -v /mocks) | |||
| - go vet $(go list ./... | grep -v /vendor) | |||
| - go get github.com/vektra/mockery/.../ | |||
| # We need kubeadm and docker for integration tests | |||
There was a problem hiding this comment.
By your command :)
pkg/etcd/etcd_test.go
Outdated
|
|
||
| const containerName string = "ectd_int_test" | ||
|
|
||
| var etcdStarted = false |
There was a problem hiding this comment.
I would not use global variables in testing. Test cases should be self contained without state leakage.
There was a problem hiding this comment.
They are, the etcd back end is only loaded once for speed and no tests use overlapping data.
There was a problem hiding this comment.
I do agree in principle but it's a trade-off I guess but for now speed over safeguarding future poor tests.
lewismarshall
force-pushed
the
integration_tests
branch
3 times, most recently
from
4eddc67
to
a3ad307
Compare
lewismarshall
force-pushed
the
integration_tests
branch
from
a3ad307
to
4011fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far added etcd.
Will Fix #40
Also Fixes #9