New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small schema issue with encryption #6244

Merged

jackyalbo merged 1 commit into noobaa:master from jackyalbo:jacky-sse-schema-fix

Nov 2, 2020

Contributor

jackyalbo commented Nov 1, 2020

Signed-off-by: jackyalbo jacky.albo@gmail.com

Explain the changes

the schema checks that context_b64 is string - the issue was that instead of setting it to undefined we set it to false - which is not a string

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

jackyalbo requested a review from jeniawhite

November 1, 2020 09:56

nimrod-becker requested a review from romayalon

November 2, 2020 08:54

romayalon approved these changes

View reviewed changes


          fix small issue with encryption

e411d73

Signed-off-by: jackyalbo <jacky.albo@gmail.com>

jackyalbo force-pushed the jacky-sse-schema-fix branch from 9b4fd73 to e411d73 Compare

November 2, 2020 08:59

jackyalbo merged commit b4b3f02 into noobaa:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment