Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tiering creation for namespace buckets #6663

Merged
merged 1 commit into from Aug 4, 2021

Conversation

dannyzaken
Copy link
Contributor

@dannyzaken dannyzaken commented Jul 13, 2021

Signed-off-by: Danny Zaken dannyzaken@gmail.com

related to noobaa/noobaa-operator#686

Explain the changes

  1. in create_bucket if the created bucket is a namespace bucket, skip the tiering\tier creation

Issues: Fixed #xxx / Gap #xxx

  1. fix for https://bugzilla.redhat.com/show_bug.cgi?id=1981331

Testing Instructions:

Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannyzaken This makes cache buckets unusable - their policy requires both namespace and tiering.

Why is this change needed??

@dannyzaken
Copy link
Contributor Author

@guymguym, you're right. changed to include cache bucket.

this is needed since this is failing creation of NS (non-cache) buckets in OCS, where the internal storage is disabled. the create_bucket fails on validate_pool_constraints. a previous fix was done in the operator by sending the default bucket class policy as the tiering policy, but it then causes OBC provision to fail if the defaultBucketClass is not ready (see noobaa/noobaa-operator#686)

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@nimrod-becker nimrod-becker merged commit f15af31 into noobaa:master Aug 4, 2021
@dannyzaken dannyzaken deleted the danny-1981331 branch August 5, 2021 07:20
@dannyzaken dannyzaken mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants