Bucket lifecycle rule creation policies compatibility with aws new API #6849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
from
0cb0592
to
9108728
Compare
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
from
9108728
to
fad4d6b
Compare
jackyalbo
requested changes
Jan 23, 2022
src/upgrade/upgrade_scripts/5.10.0/upgrade_bucket_lifecycle_structure.js
Outdated
Show resolved
Hide resolved
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
3 times, most recently
from
a2a60cd
to
4fef4e8
Compare
dannyzaken
reviewed
Jan 26, 2022
dannyzaken
reviewed
Jan 26, 2022
src/upgrade/upgrade_scripts/5.10.0/upgrade_bucket_lifecycle_structure.js
Outdated
Show resolved
Hide resolved
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
from
eeec6f5
to
e49964a
Compare
jackyalbo
requested changes
Jan 27, 2022
src/upgrade/upgrade_scripts/5.10.0/upgrade_bucket_lifecycle_structure.js
Outdated
Show resolved
Hide resolved
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
from
e49964a
to
f3be174
Compare
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
from
f3be174
to
a5911db
Compare
- Fixing bucket lifecycle rule creation policies to be compatible with aws new API - Adding Upgrade script Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-lifecycle-new-api
branch
from
a5911db
to
dfb2e0e
Compare
jackyalbo
approved these changes
Feb 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR intention is not to add any flow if there are missing, It will change the API to be compatible with AWS's new API.
due to the fact that we are not testing it, if there are missing flows they should be addressed on a different PR
https://docs.aws.amazon.com/AmazonS3/latest/API/API_LifecycleRule.html
Signed-off-by: liranmauda liran.mauda@gmail.com
Issues: Fixed #xxx / Gap #xxx