setting upgrade job restartPolicy to never #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrod-becker
approved these changes
Mar 17, 2021
dannyzaken
force-pushed
the
danny-fixes
branch
4 times, most recently
from
3804f88
to
5f41c48
Compare
nimrod-becker
approved these changes
Mar 18, 2021
jackyalbo
requested changes
Mar 18, 2021
pkg/system/phase2_creating.go
Outdated
| // setting the restart policy to never to keep the pods around after failed migrations | ||
| // also reducing the backoff limit to avoid to many pods staying around in case of an issue | ||
| r.UpgradeJob.Spec.Template.Spec.RestartPolicy = corev1.RestartPolicyNever | ||
| r.UpgradeJob.Spec.BackoffLimit = &backoffLimit | ||
| r.setDesiredCoreEnv(&r.UpgradeJob.Spec.Template.Spec.Containers[0]) |
There was a problem hiding this comment.
move this before the added code (line 1004) - so the two parts will be better divided
jackyalbo
approved these changes
Mar 21, 2021
* setting to never will keep failed pods around so we can examine the failures * set backoffLimit to 4 (default is 6) to reduce the number of pods that can potentially stay in the NS * one thing to notice is that failed runs will leave a pod (not running) with ERROR state Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restartPolicyto never will keep failed pods around so we can examine the failuresbackoffLimitto 4 (default is 6) to reduce the number of pods that can potentially stay in the NSrelated to BZ https://bugzilla.redhat.com/show_bug.cgi?id=1938557
Signed-off-by: Danny Zaken dannyzaken@gmail.com