Disable huge_pages in Postgres config #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
reviewed
Jun 16, 2021
baum
force-pushed
the
bz/1946792
branch
3 times, most recently
from
0fcb889
to
3c3fe2f
Compare
romayalon
reviewed
Jun 17, 2021
romayalon
reviewed
Jun 17, 2021
guymguym
reviewed
Jun 17, 2021
baum
force-pushed
the
bz/1946792
branch
3 times, most recently
from
3ec69ef
to
5d1098a
Compare
guymguym
reviewed
Jun 17, 2021
baum
force-pushed
the
bz/1946792
branch
2 times, most recently
from
42d9cbd
to
2a1e79a
Compare
dannyzaken
reviewed
Jun 20, 2021
There was a problem hiding this comment.
@baum - to handle upgrades you'll need to add the configMap volume and mount in SetDesiredNooBaaDB
|
@dannyzaken 10x, see the new volume, volume mounts merge logic on upgrade path https://github.com/noobaa/noobaa-operator/compare/2a1e79a..2cbbc83 |
Issue: https://bugzilla.redhat.com/show_bug.cgi?id=1946792 Test: Verify in the postgress DB container in two scenarios, (a) clean install and (b) operator upgrade: - existence and content of /opt/app-root/src/postgresql-cfg/noobaa-postgres.conf file: bash-4.2$ pwd /opt/app-root/src bash-4.2$ cat postgresql-cfg/noobaa-postgres.conf # disable huge_pages trial # see https://bugzilla.redhat.com/show_bug.cgi?id=1946792 huge_pages = off - openshift-custom-postgresql.conf includes the noobaa-postgres.conf file bash-4.2$ grep noobaa-postgres /var/lib/pgsql/openshift-custom-postgresql.conf include '/opt/app-root/src/postgresql-cfg/noobaa-postgres.conf' Verify the postgres DB is up and running with huge pages enabled in kernel. Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
dannyzaken
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
https://bugzilla.redhat.com/show_bug.cgi?id=1946792
Test:
Verify in the postgress DB container:
/opt/app-root/src/postgresql-cfg/noobaa-postgres.conffile:openshift-custom-postgresql.confincludes thenoobaa-postgres.conffileSigned-off-by: Alexander Indenbaum aindenba@redhat.com