Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 5.8 - Disable huge_pages in Postgres config #665

Merged
merged 1 commit into from Jun 21, 2021

Conversation

dannyzaken
Copy link
Contributor

Issue:
https://bugzilla.redhat.com/show_bug.cgi?id=1946792

Test:
Verify in the postgress DB container in two scenarios, (a) clean
install and (b) operator upgrade:

- existence and content of /opt/app-root/src/postgresql-cfg/noobaa-postgres.conf file:

    bash-4.2$ pwd
    /opt/app-root/src
    bash-4.2$ cat postgresql-cfg/noobaa-postgres.conf
    # disable huge_pages trial
    # see https://bugzilla.redhat.com/show_bug.cgi?id=1946792
    huge_pages = off

- openshift-custom-postgresql.conf includes the noobaa-postgres.conf file

    bash-4.2$ grep noobaa-postgres /var/lib/pgsql/openshift-custom-postgresql.conf
    include '/opt/app-root/src/postgresql-cfg/noobaa-postgres.conf'

Verify the postgres DB is up and running with huge pages enabled in
kernel.

Signed-off-by: Alexander Indenbaum aindenba@redhat.com
(cherry picked from commit 462a265)

Issue:
  https://bugzilla.redhat.com/show_bug.cgi?id=1946792

Test:
  Verify in the postgress DB container in two scenarios, (a) clean
  install and (b) operator upgrade:

    - existence and content of /opt/app-root/src/postgresql-cfg/noobaa-postgres.conf file:

        bash-4.2$ pwd
        /opt/app-root/src
        bash-4.2$ cat postgresql-cfg/noobaa-postgres.conf
        # disable huge_pages trial
        # see https://bugzilla.redhat.com/show_bug.cgi?id=1946792
        huge_pages = off

    - openshift-custom-postgresql.conf includes the noobaa-postgres.conf file

        bash-4.2$ grep noobaa-postgres /var/lib/pgsql/openshift-custom-postgresql.conf
        include '/opt/app-root/src/postgresql-cfg/noobaa-postgres.conf'

    Verify the postgres DB is up and running with huge pages enabled in
    kernel.

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
(cherry picked from commit 462a265)
@dannyzaken dannyzaken requested a review from baum June 21, 2021 08:47
Copy link
Contributor

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimrod-becker nimrod-becker merged commit c73b43f into noobaa:5.8 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants