Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regenerate S3 Credentials to the CLI #804

Merged
merged 1 commit into from Jan 16, 2022

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Nov 24, 2021

Explain the changes

Add Regenerate S3 Credentials to the CLI

Handling 3 cases:

  1. An account with no CRD and no secret
  2. An account with no CRD but with secret
  3. An account with CRD and with a secret

Signed-off-by: liranmauda liran.mauda@gmail.com

Testing Instructions:

  1. regenerate the s3 keys see that they changed and try to use them

pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Outdated Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
pkg/noobaaaccount/noobaaaccount.go Show resolved Hide resolved
Add Regenerate S3 Credentials to the CLI

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda merged commit 602e817 into noobaa:master Jan 16, 2022
@liranmauda liranmauda deleted the liran-add-regenerate-keys branch January 16, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants