Add Regenerate S3 Credentials for OBC to the CLI #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
from
9009030
to
200199e
Compare
romayalon
requested changes
Feb 22, 2022
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
from
200199e
to
d767323
Compare
romayalon
reviewed
Feb 22, 2022
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
from
d767323
to
0a3a0b1
Compare
romayalon
reviewed
Feb 23, 2022
| secret.StringData["AWS_SECRET_ACCESS_KEY"] = accessKeys.SecretKey | ||
|
|
||
| //If we will not be able to update the secret we will print the credentials as they allready been changed by the RPC | ||
| if !util.KubeUpdate(secret) { |
There was a problem hiding this comment.
@liranmauda @dannyzaken can we handle this situation better? maybe somehow hang the failure on the OBC/OB or somehow get the bucket into a rejected state and ask the user to regenerate again?
There was a problem hiding this comment.
At this point, the account credentials are already changed and we are failing to update the secret.
The apps that are using this secret will also disconnect, and as we cant revert the best way to work around it is to regenerate again, and unless there is a fundamental issue with the secret that prevents us from updating it, it will fix it.
as a middle solution, we just print the new credentials (which can be manually edited into the secret as b64, by us/support/user).
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
from
0a3a0b1
to
58af962
Compare
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
4 times, most recently
from
bfbc716
to
05a630e
Compare
dannyzaken
approved these changes
Mar 8, 2022
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
from
05a630e
to
16f6c55
Compare
- Add Regenerate S3 Credentials for OBC to the CLI Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-add-regenerate-keys-obc
branch
from
16f6c55
to
73527a9
Compare
romayalon
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Signed-off-by: liranmauda liran.mauda@gmail.com
Testing Instructions: