Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create azure StorageAccount with minTLS 1.2 #878

Merged
merged 1 commit into from Mar 16, 2022
Merged

create azure StorageAccount with minTLS 1.2 #878

merged 1 commit into from Mar 16, 2022

Conversation

dannyzaken
Copy link
Contributor

Explain the changes

  1. in azure_utils.js an old API version was used that did not have the MinimumTLSVersion property for a storage account.
  2. updated the API version and added MinimumTLSVersion=1.2

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=1970123

Testing Instructions:

  • Doc added/updated
  • Tests added

@dannyzaken dannyzaken force-pushed the danny-new-azure-sdk branch 2 times, most recently from 2dac6c3 to 054892d Compare March 16, 2022 13:20
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 16, 2022
@dannyzaken
create azure StorageAccount with minTLS 1.2
d48f921 
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@dannyzaken dannyzaken merged commit 38337d3 into noobaa:master Mar 16, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannyzaken @nimrod-becker