Add insecureEdgeTerminationPolicy to the route-s3.yaml #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is still draft as we need to verify the fix on an openshift cluster. |
|
Tested at Openshift Marking Ready to review |
|
We might want to consider changing the default to @jackyalbo @nimrod-becker WDYT? |
jackyalbo
approved these changes
Mar 15, 2022
- Add insecureEdgeTerminationPolicy to the route-s3.yaml Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-insecureEdgeTerminationPolicy
branch
from
859a61a
to
0ce6ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
https://docs.openshift.com/container-platform/4.9/rest_api/network_apis/route-route-openshift-io-v1.html
Signed-off-by: liranmauda liran.mauda@gmail.com
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: