This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Adds support for uploading files to a Slack channel #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this also generalizes the configuration in the integration tests to choose what channel the bot is in for testing.
|
Hello @metalbot - I haven't forgotten your pull request. I want to extend this to use streams instead of using the file system before accepting it 😄 |
|
I don't mind doing that, but may not be able to get to it today. |
|
@AlexJH4U you should raise an issue - pull requests are for code changes. |
|
Also @metalbot - if you are able to make a new client for uploading instead of using the chat client that would be great 👍 |
|
I've got this done, and should be able to push tomorrow. If I update the conflict on my pull request to match, will that resolve the merge conflict? |
|
Yes, I believe it should fix it |
… than filesystem based uploads.
|
Closing and resubmitting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the ISlackConnection and IChatClient interfaces to support uploading a file to slack, using mechanisms very similar to the existing Say and PostMessage implementations.
Also allows you to set the channel for integration testing (was hard coded to #general).