Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Support for uploading files to Slack #37

Merged
merged 4 commits into from
Jan 11, 2017
Merged

Support for uploading files to Slack #37

merged 4 commits into from
Jan 11, 2017

Conversation

metalbot
Copy link
Contributor

@metalbot metalbot commented Jan 6, 2017

Change summary:

  1. Create a FileClient that encapsulates the uploading of files
  2. FileClient supports either stream or filesystem based uploads
  3. Integration tests for each upload type
  4. Modifications to the config settings in the integration tests

@metalbot
Adds support for uploading files to Slack.
542947f 
Note that this also generalizes the configuration in the integration tests to choose what channel the bot is in for testing.
@metalbot
Fix a file copy that I accidentally clobbered.
f1710ad
@metalbot
Do not use ChatClient for file uploads, add support for Stream rather…
499ed03 
… than filesystem based uploads.
@metalbot metalbot mentioned this pull request Jan 6, 2017
Closed
@Workshop2
Copy link
Member

Hey @metalbot I am just doing some cleanup of this branch and then I will merge it in.

Thanks,
Simon

@Workshop2 Workshop2 merged commit 5207c07 into noobot:master Jan 11, 2017
@Workshop2
Copy link
Member

Thanks @metalbot - all merged

@Workshop2
Copy link
Member

Version 3.1.142 has been released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalbot @Workshop2