New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing bind for assert #146

Merged
merged 1 commit into from Mar 1, 2015

Conversation

Projects
None yet
2 participants
@raymondfeng
Copy link
Contributor

raymondfeng commented Feb 26, 2015

@doug-martin The previous PR is missing a bind to ensure assert has the correct receiver.

Raymond Feng

doug-martin added a commit that referenced this pull request Mar 1, 2015

Merge pull request #146 from raymondfeng/master
Add the missing bind for assert

@doug-martin doug-martin merged commit 2c6d31b into noolsjs:master Mar 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

doug-martin added a commit to doug-martin/nools that referenced this pull request Mar 2, 2015

v0.4.1
* Fixed issue with `CustomConstraint` not binding `this.assert` to `this`. noolsjs#146 - @raymondfeng
* Added more tests for custom constraints
* Updated readme to include docs about custom constraints.

@doug-martin doug-martin referenced this pull request Mar 2, 2015

Merged

v0.4.1 #147

@doug-martin

This comment has been minimized.

Copy link
Contributor

doug-martin commented Mar 2, 2015

Thanks Raymond. I added some tests to ensure we don't have any regressions on this and added some docs. Feel free to add some more docs if you can think of better examples. Thanks again!

-Doug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment