New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binlog row minimal and noblob image support #103

Merged
merged 14 commits into from Dec 29, 2014

Conversation

Projects
None yet
3 participants
@siddontang
Contributor

siddontang commented Dec 17, 2014

Only test using python 2.7, mac osx.

@bjoernhaeuser

This comment has been minimized.

Show comment
Hide comment
@bjoernhaeuser

bjoernhaeuser Dec 20, 2014

Collaborator

Can you please fix and some tests?

Collaborator

bjoernhaeuser commented Dec 20, 2014

Can you please fix and some tests?

siddontang added some commits Dec 21, 2014

try fix again
TypeError: unsupported operand type(s) for &: 'float' and 'int'
try fix, I hate python's dynamic type
TypeError: 'float' object cannot be interpreted as an integer
try fix error
TypeError: bytearray indices must be integers
try fix
error: unpack requires a string argument of length 4
try fix
error: unpack requires a string argument of length 4
@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Dec 22, 2014

Contributor

Sorry that I have not used python for nearly 2 years and fixing errors for different python version drives me crazy 😢

Contributor

siddontang commented Dec 22, 2014

Sorry that I have not used python for nearly 2 years and fixing errors for different python version drives me crazy 😢

@bjoernhaeuser

This comment has been minimized.

Show comment
Hide comment
@bjoernhaeuser

bjoernhaeuser Dec 23, 2014

Collaborator

What do yo think about having some specific tests for Bitmap?

Collaborator

bjoernhaeuser commented Dec 23, 2014

What do yo think about having some specific tests for Bitmap?

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang

siddontang Dec 24, 2014

Contributor

Well, testing bitmap may be not easy, is it ok to test MySQL row image instead?

Contributor

siddontang commented Dec 24, 2014

Well, testing bitmap may be not easy, is it ok to test MySQL row image instead?

@bjoernhaeuser

This comment has been minimized.

Show comment
Hide comment
@bjoernhaeuser

bjoernhaeuser Dec 28, 2014

Collaborator

@noplay what do you think? I think we can merge it :)

Collaborator

bjoernhaeuser commented Dec 28, 2014

@noplay what do you think? I think we can merge it :)

@noplay

This comment has been minimized.

Show comment
Hide comment
@noplay

noplay Dec 29, 2014

Owner

You are right ! Sorry with christmas i was busy.

Owner

noplay commented Dec 29, 2014

You are right ! Sorry with christmas i was busy.

noplay added a commit that referenced this pull request Dec 29, 2014

Merge pull request #103 from siddontang/master
add binlog row minimal and noblob image support

@noplay noplay merged commit 6879d41 into noplay:master Dec 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment