From 37f8cf208fb86f91f6984c0ef0b7c8817729e55c Mon Sep 17 00:00:00 2001 From: Jon Newmuis Date: Thu, 20 Dec 2018 17:50:21 -0500 Subject: [PATCH] Hide the share pill in visual tests, and re-enable tests that were flaky because of this (#20022) --- .../amp-story/amp-story-bookend.html | 10 ++++++ .../amp-story/amp-story-bookend.rtl.html | 10 ++++++ .../amp-story/amp-story-consent.html | 10 ++++++ .../amp-story/amp-story-consent.rtl.html | 10 ++++++ .../amp-story/amp-story-cta-layer.html | 10 ++++++ .../amp-story-grid-layer-template-fill.html | 10 ++++++ ...-story-grid-layer-template-horizontal.html | 10 ++++++ .../amp-story-grid-layer-template-thirds.html | 10 ++++++ ...mp-story-grid-layer-template-vertical.html | 10 ++++++ .../amp-story-pagination-buttons.html | 9 +++++ .../amp-story/amp-story-sidebar.html | 9 +++++ .../amp-story/amp-story-tooltip.html | 10 ++++++ examples/visual-tests/amp-story/basic.html | 10 ++++++ .../visual-tests/amp-story/basic.rtl.html | 10 ++++++ .../visual-tests/amp-story/embed-mode-1.html | 10 ++++++ .../visual-tests/amp-story/embed-mode-2.html | 10 ++++++ .../visual-tests/amp-story/info-dialog.html | 10 ++++++ .../amp-story/info-dialog.rtl.html | 10 ++++++ .../visual-tests/amp-story/share-menu.html | 10 ++++++ .../amp-story/share-menu.rtl.html | 10 ++++++ test/visual-diff/visual-tests | 34 +------------------ 21 files changed, 199 insertions(+), 33 deletions(-) diff --git a/examples/visual-tests/amp-story/amp-story-bookend.html b/examples/visual-tests/amp-story/amp-story-bookend.html index f62ae1757156e..ec43d4c7f7900 100644 --- a/examples/visual-tests/amp-story/amp-story-bookend.html +++ b/examples/visual-tests/amp-story/amp-story-bookend.html @@ -23,6 +23,16 @@ display: none; } + /* + * The share pill text does not show in the same place consistently, and + * as such causes the visual tests to be flaky. This hides the share pill + * with visibility: hidden, so as to keep other elements in the same place + * that they would otherwise be, while deflaking the tests. See #19890. + */ + .i-amphtml-story-share-pill { + visibility: hidden; + } + h1.hello-world { color: white; text-align: center; diff --git a/examples/visual-tests/amp-story/amp-story-bookend.rtl.html b/examples/visual-tests/amp-story/amp-story-bookend.rtl.html index 29bbb2060d547..3074aed9c4e59 100644 --- a/examples/visual-tests/amp-story/amp-story-bookend.rtl.html +++ b/examples/visual-tests/amp-story/amp-story-bookend.rtl.html @@ -23,6 +23,16 @@ display: none; } + /* + * The share pill text does not show in the same place consistently, and + * as such causes the visual tests to be flaky. This hides the share pill + * with visibility: hidden, so as to keep other elements in the same place + * that they would otherwise be, while deflaking the tests. See #19890. + */ + .i-amphtml-story-share-pill { + visibility: hidden; + } + h1.hello-world { color: white; text-align: center; diff --git a/examples/visual-tests/amp-story/amp-story-consent.html b/examples/visual-tests/amp-story/amp-story-consent.html index 4d887095f54f1..3fa30d3815a9d 100644 --- a/examples/visual-tests/amp-story/amp-story-consent.html +++ b/examples/visual-tests/amp-story/amp-story-consent.html @@ -25,6 +25,16 @@ display: none; } + /* + * The share pill text does not show in the same place consistently, and + * as such causes the visual tests to be flaky. This hides the share pill + * with visibility: hidden, so as to keep other elements in the same place + * that they would otherwise be, while deflaking the tests. See #19890. + */ + .i-amphtml-story-share-pill { + visibility: hidden; + } + h1#hello-world { color: white; text-align: center; diff --git a/examples/visual-tests/amp-story/amp-story-consent.rtl.html b/examples/visual-tests/amp-story/amp-story-consent.rtl.html index a5961afdd6f7b..d9b54dcd87d50 100644 --- a/examples/visual-tests/amp-story/amp-story-consent.rtl.html +++ b/examples/visual-tests/amp-story/amp-story-consent.rtl.html @@ -25,6 +25,16 @@ display: none; } + /* + * The share pill text does not show in the same place consistently, and + * as such causes the visual tests to be flaky. This hides the share pill + * with visibility: hidden, so as to keep other elements in the same place + * that they would otherwise be, while deflaking the tests. See #19890. + */ + .i-amphtml-story-share-pill { + visibility: hidden; + } + h1#hello-world { color: white; text-align: center; diff --git a/examples/visual-tests/amp-story/amp-story-cta-layer.html b/examples/visual-tests/amp-story/amp-story-cta-layer.html index 9642bb73c25de..e929a9c793087 100644 --- a/examples/visual-tests/amp-story/amp-story-cta-layer.html +++ b/examples/visual-tests/amp-story/amp-story-cta-layer.html @@ -24,6 +24,16 @@ left: 50%; transform: translate(-50%, -50%); } + + /* + * The share pill text does not show in the same place consistently, and + * as such causes the visual tests to be flaky. This hides the share pill + * with visibility: hidden, so as to keep other elements in the same place + * that they would otherwise be, while deflaking the tests. See #19890. + */ + .i-amphtml-story-share-pill { + visibility: hidden; + }