Rebuild the Sectile logic #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a lot of testing Flourish v0.10's new Sectile fragments editing interface in the blueprint page, I realised I hadn't been using the source/type dimensions well. "source" is an overloaded term, meaning both a page source (a TOML or Markdown file definining a page), an output web page (Flourish calls the generator for most sources SourceGenerator, and I am using `source` as the reference name in `generate.py`) so using it as the dimension to represent "the source of the source" was one to many. This commit changes the dimension "source" to "origin" to be clearer, but doesn't change any source to use the new dimension. That will come in the next set of commits.
For the Sectile updates: * source:"api.github.com" becomes origin:"github" * type:"github" becomes type:"repository_activity" Adds repositories mentioned in the log as metadata, both as the raw in `repository`, and in slugified form in `tag`.
Option-Space on macOS provides a non-breaking space. I'll sometimes accidentally type this next to using Option-Hyphen to get an em- or en-dash. And I didn't notice this until Sublime Text 3 started highlighting them.
For the Sectile updates: * source:"instagram" becomes origin:"instagram" * type:"instagram" becomes type:"photo" Other metadata updates: * put published after title
For the Sectile updates:
* source:"twitter" becomes origin:"twitter-norms_ps4"
Other metadata updates:
* source_url becomes original_url
* a little rearranging of the order of keys
* camel-cased hashtags (#RedDeadRedemption2) are now hyphenated when
added as tags (reddeadredemption2 becomes red-dead-redemption-2)
* images are HTTPS
For the Sectile updates: * source:"twitter" becomes origin:"twitter-cackhanded" Other metadata updates: * source_url becomes original_url * a little rearranging of the order of keys * camel-cased hashtags are now hyphenated * images are HTTPS
For the Sectile updates: * source:"Foursquare (Swarm)" becomes origin:"foursquare" * type:"foursquare" becomes type:"checkin" Other metadata updates: * put published after title
For the Sectile updates: * source:"YouTube (... channel)" becomes origin:"youtube" * type:"youtube" becomes type:"video" * adds origin_link_text:"... channel" * adds origin_link_url:[channel url] Other metadata updates: * put published after title * move video_id up
They are found in the description, and from the channel name (except where it is just my name, that's superflouous).
For the Sectile updates: * source:"gifs.cackhanded.net" becomes origin:"gifs" * the key source_url becomes origin_link_url
Ensure everything has an origin key and nothing has a source key. Remove accidental duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of testing Flourish v0.10's new Sectile fragments editing
interface in the blueprint page, I realised I hadn't been using the
source/type dimensions well.
"source" is an overloaded term, meaning both a page source (a TOML or
Markdown file definining a page), an output web page (Flourish calls the
generator for most sources SourceGenerator, and I am using
sourceasthe reference name in
generate.py) so using it as the dimension torepresent "the source of the source" was one to many.
Rebuild the Sectile templates to use the new dimensions.