Permalink
Commits on Jan 7, 2016
  1. Frienldy_id should not generate a slug when all of canidates is nil.

    Previously `friendly_id_config.base` was checked on presence in `should_generate_new_friendly_id?`. And let's imagine
    that we have multiple slug candidates, but all of them is nil. In this case we will have something like
    `[nil, nil]` as base for slug and `presence?` for this array will be evalutated to true. But all of slug canidates is nil, right?
    Booom! Exception during execution of `resolve_friendly_id_conflict`.
    kimrgrey committed Jan 7, 2016
  2. Merge pull request #718 from norman/issue#717

    Fixed problem that occurred when module :history was used after :finders.
    kimrgrey committed Jan 7, 2016
Commits on Jan 3, 2016
  1. Merge pull request #719 from Atul9/master

    Update copyright notices to 2016.
    kimrgrey committed Jan 3, 2016
Commits on Jan 1, 2016
  1. Specified versions of mysq2 in Gemfile for Rails 4.0 and Rails 4.1.

    Maximum version of mysql2 that works with Rails 4.0 is 0.3.10. Maximum version of mysql2 that works with Rails 4.1 is 0.3.13.
    Older versions are not suppoted by ActiveRecord and couldn't be used for tests on those versions on Rails.
    kimrgrey committed Jan 1, 2016
  2. Model class is extended by FriendlyId::Finders::ClassMethods in setup…

    … FriendlyId::Finders.setup instead of included.
    
    Because relation_delegate_class is needed for correct extending of ActiveRecord::AssociationRelation
    with finder methods.
    kimrgrey committed Jan 1, 2016
  3. Renamed HistoryTestWithFriendlyFindersModuleBeforeHistory to HistoryT…

    …estWithFindersBeforeHistory.
    
    Test was broken on Travis CI because Name HistoryTestWithFriendlyFindersModuleBeforeHistory::Novelist is
    too long for sluggable_type.
    kimrgrey committed Jan 1, 2016
  4. Fixed problem that occurred when module :history was used after modul…

    …e :finders.
    
    Module finders includes methods from friendly_id_config.finder_methods into base class. But module :history replaces this methods.
    So, to make :finders and :history works together those methods must be reincluded into base class during initialization of :history.
    
    Please, see #717 for problem details.
    kimrgrey committed Jan 1, 2016
Commits on Nov 11, 2015
  1. Embolden the link to the more comprehensive docs

    cllns committed Nov 11, 2015
Commits on Oct 15, 2015
Commits on Sep 22, 2015
  1. Merge pull request #694 from abookyun/fix-migration

    Specify length of multi-column index name
    committed Sep 22, 2015
  2. Make maximum use of 767 bytes

    David Yun committed Sep 22, 2015
Commits on Aug 20, 2015
Commits on Aug 10, 2015
  1. Merge pull request #693 from MatthewRDodds/fix-documentation

    Update documentation where example model omits inclusion of library
    committed Aug 10, 2015
Commits on Jul 31, 2015
  1. Merge pull request #688 from kangkyu/patch-1

    Update CONTRIBUTING.md
    parndt committed Jul 31, 2015
Commits on Jul 27, 2015
  1. Update CONTRIBUTING.md

    fix one typo
    kangkyu committed Jul 27, 2015
Commits on Jun 7, 2015
  1. Merge pull request #673 from dgynn/find_by_find_by

    Use ActiveRecord's find_by to perform the query in finder_methods
    committed Jun 7, 2015
Commits on Jun 6, 2015
Commits on Jun 1, 2015
  1. Document common gotcha in initializer

    Resolves #650
    
    [ci skip]
    committed Jun 1, 2015
  2. Update changelog

    [ci skip]
    committed Jun 1, 2015
  3. Set slug to previous value on validation failure

    On create, set slug to nil if unrelated validations fail.
    
    On save, set slug to previous value if unrelated validations fail.
    
    Without this change, Rails forms will sometimes use a new, unpersisted
    slug value as the form action URL, and submitting the form will result
    in a 404.
    
    Resolves #642
    committed Jun 1, 2015
Commits on May 31, 2015
  1. use ActiveRecord find_by to query for the object

    this has the benefit of leaving off the order by SQL and
    will use the find_by statement cache of the object
    dgynn committed May 31, 2015
  2. fix refences to FFaker

    dgynn committed May 31, 2015
Commits on May 29, 2015
  1. Merge pull request #671 from sublimecoder/add-gorails-video-to-docume…

    …ntation
    
    add GoRails video to readme documentation
    committed May 29, 2015
Commits on May 24, 2015
  1. change sort to use ID, since it is guaranteed unique where created_at…

    … is not and we are looking for a single unique record
    mtuckergd committed with Apr 19, 2015
  2. Bumped version

    committed May 24, 2015
  3. Updated changelog

    committed May 24, 2015