Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't work with rails 3.2.9.rc1 #332

Closed
tomkrus opened this Issue Oct 30, 2012 · 16 comments

Comments

Projects
None yet
6 participants

tomkrus commented Oct 30, 2012

Params ID don't find... etc.

http://www.ruby-forum.com/topic/4407271

Got the same here too. Looks like the overloading of find to use the friendly_id slug isn't working.

phoet commented Oct 31, 2012

having the same error with friendly_id 4.0.8 and rails 3.2.9.rc1.

before:

Event Load (0.1ms)  SELECT "events".* FROM "events" WHERE "events"."label" = 'hamburg' AND "events"."slug" = 'weihnachtstreffen-2001' ORDER BY date DESC LIMIT 1

after:

Event Load (0.1ms)  SELECT "events".* FROM "events" WHERE "events"."label" = 'hamburg' AND "events"."id" = ? ORDER BY date DESC LIMIT 1  [["id", "weihnachtstreffen-2001"]]

can you test that using rails 3-2-stable branch?. Let me know the results please.

tomkrus commented Oct 31, 2012

For rails 3.2.8 - 3.2.8.rc2 it's fine.

@tomkrus we need you to use in your Gemfile

gem 'rails', github: 'rails/rails', branch: '3-2-stable'

@phoet can you bisect Rails to find the offending commit?

phoet commented Oct 31, 2012

will try tomorrow

Von meinem iPhone gesendet

Am 31.10.2012 um 19:15 schrieb Santiago Pastorino <notifications@github.com

:

@phoet https://github.com/phoet can you bisect Rails to find the
offending commit?


Reply to this email directly or view it on
GitHubhttps://github.com/norman/friendly_id/issues/332#issuecomment-9955855.

@phoet ok I will wait, let me know ASAP please this is holding 3.2.9.rc2

phoet commented Oct 31, 2012

this is the commit: rails/rails@8dbf337

This seems unrelated. That commit is changing relation cache and your failure is related with SQL building.

@phoet try on top of last 3-2-stable doing git revert 8dbf337 and let us know

I've tried in that's the commit that break his code. /cc @norman

Owner

norman commented Nov 1, 2012

Thanks everybody for the discussion and info. I'm looking at this now and will try to get a solution in place ASAP.

norman added a commit that referenced this issue Nov 1, 2012

Owner

norman commented Nov 1, 2012

Ok, I've resolved the issue and pushed a new version (4.0.9) to Rubygems. Thanks again for the helpful bug reporting!

@norman norman closed this Nov 1, 2012

phoet commented Nov 1, 2012

i can confirm that this works:

gem "rails",                "3.2.9.rc1"
gem "friendly_id",          "4.0.9"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment