Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Document necessary location of slug column with Globalize #308

Merged
merged 1 commit into from Jul 3, 2012

Conversation

Projects
None yet
3 participants
Contributor

robyurkowski commented Jul 3, 2012

This adds a point of clarification in the rdoc and inside the globalize module itself to point out that the slug column must be present on the translation table, not the primary model table itself. It also (real friendly-like) corrects some faulty parallelism.

Resolves #293.

Contributor

robyurkowski commented Jul 3, 2012

Sorry for the stupid second commit.

Collaborator

parndt commented Jul 3, 2012

Thanks can you please squash the commits?

@robyurkowski robyurkowski Document necessary location of slug column (resolves #293)
This adds a point of clarification in the rdoc and inside the globalize module itself to point out that the slug column must be present on the translation table, not the primary model table itself. It also (real friendly-like) corrects some faulty parallelism.
dc78438
Contributor

robyurkowski commented Jul 3, 2012

Flat like an ugly bug.

@parndt parndt added a commit that referenced this pull request Jul 3, 2012

@parndt parndt Merge pull request #308 from robyurkowski/master
Document necessary location of slug column with Globalize
30e663d

@parndt parndt merged commit 30e663d into norman:master Jul 3, 2012

Collaborator

parndt commented Jul 3, 2012

👍

Owner

norman commented Jul 4, 2012

Thanks for working on this. However, IMO it's just as unclear as the original, but in the opposite way. Now some people are going to think they don't need a slug column in their model - something that's been asked several times and was the motivation for 4aba14f.

Contributor

robyurkowski commented Jul 4, 2012

That's my error, @norman, sorry. Hope this should help clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment