Clarify globalize slug documentation further #309

Merged
merged 1 commit into from Jul 4, 2012

2 participants

@robyurkowski

In response to @norman's comment here:

The previous change made in dc78438 lost clarity when it assumed parallelism, when in fact the first object had changed with the same commit. Now it should be clearer that the model must set the slug column translatable, not the translation table.

@norman
Owner

Sorry, but it's still not clear. I think it should say something like:

In order to use this module, your model's table and translation table must both have a slug
column, and and your model must set the +slug+ field as translatable with Globalize.

@robyurkowski

I was about to ask this, because I'm currently translating a few tables and things are blowing up without that. I was going by what was said in #293, though I think I understand where we misconnected.

Third time's the charm — I'll correct and squash shortly.

@robyurkowski robyurkowski Clarify globalize slug documentation further
It should now be clear that both the model's table and the model's
translation table must have a slug field, and the model must declare the
slug field translatable.
7b9a30d
@robyurkowski

There we go.

@norman norman merged commit 4052027 into norman:master Jul 4, 2012
@norman
Owner

Pulled, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment