Clarify globalize slug documentation further #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but it's still not clear. I think it should say something like:
|
|
I was about to ask this, because I'm currently translating a few tables and things are blowing up without that. I was going by what was said in #293, though I think I understand where we misconnected. Third time's the charm — I'll correct and squash shortly. |
It should now be clear that both the model's table and the model's translation table must have a slug field, and the model must declare the slug field translatable.
|
There we go. |
norman
added a commit
that referenced
this pull request
Jul 4, 2012
Clarify globalize slug documentation further
|
Pulled, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to @norman's comment here:
The previous change made in dc78438 lost clarity when it assumed parallelism, when in fact the first object had changed with the same commit. Now it should be clearer that the model must set the slug column translatable, not the translation table.