Skip to content

Norman Maurer
normanmaurer

Organizations

@netty @barchart @mashupbots @vert-x @xnio @reactive-streams @grpc @apple
Jul 1, 2016
normanmaurer commented on issue netty/netty#5486
@normanmaurer

@tjake ok... can you tell me why you think the handlerState should be volatile ?

Jul 1, 2016
normanmaurer commented on issue netty/netty#5486
@normanmaurer

@JeremiahDJordan also do you modify the pipeline from outside the EventLoop at all ?

Jul 1, 2016
normanmaurer commented on issue netty/netty#5486
@normanmaurer

@tjake @JeremiahDJordan as far as I remember this is only ever accessed / modified from the same thread. Do I miss something ?

Jul 1, 2016
normanmaurer commented on issue netty/netty#5486
@normanmaurer

Hmm ... Can you also try 4.0.38.Final? Also is it using nio or epoll? Can I run the testsuite locally somehow? Am 01.07.2016 um 21:12 schrieb Jere…

Jul 1, 2016
normanmaurer commented on pull request netty/netty#5485
@normanmaurer

thanks sounds good

Jul 1, 2016
normanmaurer commented on pull request netty/netty#5482
@normanmaurer

LGTM

Jul 1, 2016
normanmaurer commented on pull request netty/netty#5479
@normanmaurer

@tbrooks8 @Scottmitch yeah I think we only allow to set a max capacity when using the SingleThreadEventExecutor, and so we only need to care about …

Jul 1, 2016
normanmaurer commented on pull request netty/netty#5471
@normanmaurer

@Scottmitch can you tell me which one ?

Jul 1, 2016
normanmaurer commented on pull request netty/netty#5479
@normanmaurer

Doh! Did not spot it.... Will cleanup Am 01.07.2016 um 17:24 schrieb Scott Mitchell notifications@github.com: In common/src/main/java/io/netty/uti…

Jul 1, 2016
normanmaurer commented on pull request netty/netty#5471
@normanmaurer

@Scottmitch netty not builds with java6 so no we not run java6 on our ci servers ;)

Jul 1, 2016
normanmaurer closed pull request netty/netty#5479
@normanmaurer
Remove unneeded calls to hasScheduledTasks() when fetching from scheduled task queue for event executors
Jul 1, 2016
normanmaurer commented on pull request netty/netty#5479
@normanmaurer

Cherry-picked into 4.1 (181c159) and 4.0 (8c2c2be)

Jul 1, 2016
@normanmaurer
  • @tbrooks8 8c2c2be
    Remove unneeded calls to hasScheduledTasks() when fetching from sched…
Jul 1, 2016
@normanmaurer
  • @tbrooks8 181c159
    Remove unneeded calls to hasScheduledTasks() when fetching from sched…
Jul 1, 2016
normanmaurer commented on pull request netty/netty#5450
@normanmaurer

I checked after I cut the release and could not spot any error.

Jul 1, 2016
@normanmaurer
  • @normanmaurer 791a8bb
    Deploy site '5765b45' on 2016-07-01 13:05:21
Jul 1, 2016
normanmaurer commented on pull request grpc/grpc-java#1999
Jul 1, 2016
@normanmaurer
Jul 1, 2016
@normanmaurer
Jul 1, 2016
Jul 1, 2016
@normanmaurer
  • @normanmaurer 4329e97
    [maven-release-plugin] prepare for next development iteration
Jul 1, 2016
Jul 1, 2016
@normanmaurer
  • @normanmaurer 8642f16
    [maven-release-plugin] prepare release netty-4.0.38.Final
Jul 1, 2016
@normanmaurer
When I deployed to linux and start, after a while netty throws a warn
Jul 1, 2016
normanmaurer commented on issue netty/netty#5470
@normanmaurer

Ok let me close it then

Jun 30, 2016
normanmaurer commented on pull request netty/netty#5479
@normanmaurer

@Scottmitch PTAL as well

Jun 30, 2016
normanmaurer commented on pull request netty/netty#5479
@normanmaurer

@tbrooks8 why do we need the if check here ? Isn't this checked by the while loop already ?

Jun 30, 2016
normanmaurer closed pull request netty/netty#5473
@normanmaurer
Use reflection to call cleaner on direct byte buffers in JDK9
Jun 30, 2016
normanmaurer commented on pull request netty/netty#5473
@normanmaurer

Cherry-picked into 4.1 (34d8b51) and 4.0 (5b92ada)

Jun 30, 2016
@normanmaurer
  • @varming 5b92ada
    Use reflection to call cleaner on direct byte buffers in JDK9.
Something went wrong with that request. Please try again.