Zebra breaks everything again #11
Merged
Conversation
added 5 commits
Sep 7, 2020
…dronecaster into zebra_breaks_everything
…dronecaster into zebra_breaks_everything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
so i had a total git failure on the last one and the refactor was not even in there. woops!(uh... no, the old changes are in yourmain? i dunno wtf happened, oh well)(oh cause the last PR was merged after 04baac1, ahh, the world makes sense again.)
so, sorry for double PR,
but this actually adds the crossfading behavior.replaced NodeProxy with new custom classDronecaster_SynthSocket, which queues a single synth function for crossfading instead of attempting to allocate arbitrary numbers of voices.(no, i still have not got this on the norns hardware this weekend, sorry... the reason is that my norns unit is set up in the middle of a massive and complex stage of
cronedevelopment and i have so little time i would rather not be switching things around on it...)also tweaked some of the synth parameters...