Solid Nodes and Extra-Nodes #3377

vicdoval · 2020-06-28T13:41:37Z

This PR adds two features:

Extra nodes: The ability to add nodes with external dependencies.
A new tab has been added to the sverchok preferences to handle the dependencies

In case of missing dependencies the nodes wont be loaded and they wont appear on the menu.
If a file is loaded with nodes that require dependencies not found a Dummy node will be created on the Fly

The dependent nodes have to be added to the dummy_nodes_dict in utils/dummy_nodes
I followed the strategy of the old_nodes loading but generating the dummy_nodes when needed
Also if a json is loaded with nodes that require dependencies not found they will be replaced by a Dummy node

Solid Nodes: A set of nodes dependent on FreeCad to perform operations with solids (BRep)
Inspired in https://blenderartists.org/t/freecad-sverchok-subd-to-nurbs/1218702
Using FreeCAD as Python module a set of nodes to deal with solids

Installation
A python 3.7 FreeCad is needed. a windows version can be found here https://github.com/sgrogan/FreeCAD/releases/tag/PY3.7-win
Then the path to the FreeCad bin folder has to be placed in the Extra-Nodes ->FreeCad-> TextField and click on Set Path

Solids are heavier than meshes but perform better boolean operations (even with co-planar faces)
The module also offers variable radius Fillet

Chamfer with different angles:

And more to came (import/export to STL and BRep, center of mass, solid to NURBS...)

Code changes complete.
Code documentation complete.
Documentation for users complete (or not required, if user never sees these changes).
Manual testing done.
Unit-tests implemented.
Ready for merge.

…lid_nodes

zeffii · 2020-06-28T16:46:35Z

oh lol. i see you have Mesh to Solid already. i'm blind.

portnov · 2020-06-28T17:12:19Z

Well. We have to decide something... We discussed this in portnov/sverchok-extra#15
If there will be "Extra nodes" subsystem in Sverchok, do we need Sverchok-Extra at all?

vicdoval · 2020-06-28T18:48:28Z

@portnov I took part some of the code from sverchok-extra to make this PR work, Sverchok-extra is a extra step, the easiest, but another step. I think moving sv-extra to extra-nodes will encourage the users to install the dependencies and to use the nodes ...

vicdoval · 2020-06-29T13:34:39Z

Solid Edges node outputs Curve objects:

portnov · 2020-06-29T20:10:41Z

Do I correctly understand that the path that I have to set up in preferences is the path to FreeCAD.so / FreeCAD.dll ? This is not too clear. I suggest to write it in the tooltip or in special label nearby. Also I suggest to add examples of typical paths on different platforms there.
Why separate Set button is required?
When I put /usr/lib/freecad-python3/lib/ there, I have

FreeCAD 0.18.4, Libs: 0.18.4R
No modules found in /usr/lib/freecad-python3/Mod
During initialization the error No module named 'freecad' occurred

However the nodes seem to work. What is going on? :)

If I try to do "Mesh to Solid", and then do something with that Solid (Fillet, for example, or Champfer), I have

Traceback (most recent call last):
  File "/home/portnov/.config/blender/2.82/scripts/addons_contrib/sverchok/core/update_system.py", line 383, in do_update_general
    node.process()
  File "/home/portnov/.config/blender/2.82/scripts/addons_contrib/sverchok/nodes/solid/fillet_solid.py", line 62, in process
    solid_o = solid.makeFillet(r_s, r_e, selected_edges)
Part.OCCError: BRep_API: command not done

The same node works if I pass primitive like "Box (Solid)" into it.

vicdoval · 2020-06-30T07:52:31Z

Do I correctly understand that the path that I have to set up in preferences is the path to FreeCAD.so / FreeCAD.dll ? This is not too clear. I suggest to write it in the tooltip or in special label nearby. Also I suggest to add examples of typical paths on different platforms there.

The path has to be to the folder where FreeCadApp.dll (and the FreeCadBase.exe..) is placed... In my case is something like E:\programas\conda-0.18.3\bin (it is a portable Windows version of FreeCad downloaded from the provided link)

Why separate Set button is required?

The Set button saves a file in python\lib\site-packages called freecad_path.pth with the supplied path so it stays permanently on the system... maybe it could be set every time you open blender.. I thought this solution was cleaner but I'm open to suggestions

However the nodes seem to work. What is going on? :)

Probably you already had a path in your system to the right version of FreeCAD

About the 4th point: The FreeCAD api report is a bit obscure..., the Fillet and Chamfer nodes will fail if the Radius/Distance is to high to perform the operation without errors, reducing the value should make it work. maybe I should add a try/except to raise a more clear explanation

zeffii · 2020-06-30T08:07:57Z

looks like the vdmk3 might need an alternative, for solids to avoid that chevron shading artifact in the fillet, but if each surface that is currently outlined by an edge is ultimately just one "polygon", then things become tricky.

vicdoval · 2020-06-30T08:50:27Z

Solid Faces node outputs surface objects and curves with the outer curves of each face:

vicdoval · 2020-06-30T08:55:19Z

@zeffi i was thinking about this... in grashopper some nodes have a draw method that works like a inner viewer draw... now that we have Surfaces, Curves and Solids maybe could try something similar...
As you see in this images there could be a cleaner way to represent the Solid objects

The faces are tesselated but only the "real" edges are represented....

zeffii · 2020-06-30T09:09:17Z

"Solid Viewer" as a separate node maybe, an opportunity to go beyond my silly experiments.

zeffii · 2020-06-30T10:10:40Z

coooool.

zeffii · 2020-06-30T11:00:53Z

should the Solids get their own separate menu? even if it's only a really minor menu system.

- input
- operators
- convert
- output

vicdoval · 2020-06-30T12:15:23Z

@zeffi you mean taking it out of the general menu or keep it there and also making another smaller menu?

zeffii · 2020-06-30T12:23:47Z

yes, to do this justice i think a separate menu has merit. Especially for the new users, who will be able to see what is available from the FreeCAD module in a nice menu/submenu form

whats happening here?

https://gist.github.com/f2406acbfa3b721d9926d6b912065f54

vicdoval · 2020-06-30T13:22:38Z

whats happening here?

It was me messing with curves... now is fixed

I understand you mean keeping in main + new menu?

The question that pops up is: A freeCad module menu or a Solids Menu? Once FreeCad is inside Sv we could import more than Solids... (BIM, Fem analysis, Surface, Mesh tools [there is a mesh boolean operator])... how do you imagine it?

zeffii · 2020-06-30T13:38:50Z

how do you imagine it?

well, in the overarching case that you paint, maybe a freeCAD menu would indeed make sense.

In that case I would vote to not mix those nodes in the Sverchok menu at all. but let's see.

portnov · 2020-06-30T16:08:16Z

@vicdoval

The Set button saves a file in python\lib\site-packages called freecad_path.pth with the supplied path so it stays permanently on the system... maybe it could be set every time you open blender.. I thought this solution was cleaner but I'm open to suggestions

Does this mean I have to press this button each time I run blender?

Wouldn't it be enough to just save the path in sverchok settings and initialize sys.path accordingly at registration?

portnov · 2020-06-30T16:11:52Z

2020-06-30 21:09:10,122 [ERROR] sverchok.core.update_system: Node Chamfer Solid had exception: BRep_API: command not done
Traceback (most recent call last):
  File "/home/portnov/.config/blender/2.82/scripts/addons_contrib/sverchok/core/update_system.py", line 383, in do_update_general
    node.process()
  File "/home/portnov/.config/blender/2.82/scripts/addons_contrib/sverchok/nodes/solid/chamfer_solid.py", line 63, in process
    solid_o = solid.makeChamfer(d_a, d_b, selected_edges)
Part.OCCError: BRep_API: command not done

portnov · 2020-06-30T16:36:23Z

"Solid faces" node. Is it possible to have additional output similar to "Outer Wire", but with curves in UV coordinates of each surface? I just don't know if Freecad provides such.

portnov · 2020-06-30T16:41:37Z

Dummy nodes. Do we really need separate classes for them? Maybe that "dummy" functionality could be incorporated in the nodes themselves?

from sverchok.dependencies import FreeCAD

class SvSomeNode:
    def is_dummy(self):
        return (FreeCAD is None)
    
    def draw(...):
        if self.is_dummy(): layout.label(text="This is a dummy node")
        else: draw actual UI

    def process(self):
        if self.is_dummy(): raise Exception("This is a dummy node")

?

portnov · 2020-06-30T18:01:53Z

https://github.com/microelly2/NodeEditor huh.

portnov · 2020-07-06T09:31:35Z

👍

zeffii · 2020-07-06T09:51:27Z

🎉

now to make some coool stuff with it.

nortikin · 2020-07-06T23:08:26Z

https://vk.com/wall-35076122_11309
short installation instructions on linux and windows:

Linux:
sudo apt install libfreecad-python3-0.18
/usr/lib/freecad-python3/lib/
Windows:
https://github.com/sgrogan/FreeCAD/releases/tag/PY3.7-win
E:\programs\conda-0.18.3\bin

rastart · 2020-09-13T16:29:29Z

Hello everyone!
I'm the author of the blender artist post: https://blenderartists.org/t/freecad-sverchok-subd-to-nurbs/1218702
I'm starting to study this implementation and I rewrited my original sv project node.
Here node features:

it takes a freecad project file and output the solids from it
it writes a mesh from blender overwriting the given name

I see that is possible to slice the solid list and make operation on it, but It would be nice to add a node to select parts by name, I have to try…

If could be of some use here the node code:
SvFCproject.zip

portnov · 2020-09-13T16:50:18Z

I would suggest

Split reading and writing into different nodes;
For reading node, add "Read List" button, which would read list of objects from FreeCAD's file and populate a dropdown list (or a list with checkboxes, so that the user can select several objects)
Probably, support "SvFilePath" socket for file path.

rastart · 2020-09-20T11:08:29Z

I would suggest

Split reading and writing into different nodes;

For reading node, add "Read List" button, which would read list of objects from FreeCAD's file and populate a dropdown list (or a list with checkboxes, so that the user can select several objects)

Probably, support "SvFilePath" socket for file path.

Hello! working in progress... Slowly learning Sverchok framework...
FCStd node splitted:

"read node"
It can import from multiple files but I didn't find a way to populate a dropdown list of the parts to select, so I added a field to filter by name, just writing parts name separated by comma and no spaces ( split(',')... )

"write node" ( mesh/solid modes)
I still have to code multiple file writing in write node.
I tried to write a solid input from the "mesh to solid" node, it works!
The parts writed from blender are overwrited by name in the FCStd file.
The solid write mode support multiple solids and it will add an index on the base name, on changes it will delete all parts with base name before write them again. This system could be quite dangerous... It's just a way to experiment with blender/CAD workflow.

FCStd_nodes.zip

nortikin · 2020-09-21T10:20:00Z

I would suggest

Split reading and writing into different nodes;

For reading node, add "Read List" button, which would read list of objects from FreeCAD's file and populate a dropdown list (or a list with checkboxes, so that the user can select several objects)

Probably, support "SvFilePath" socket for file path.

Hello! working in progress... Slowly learning Sverchok framework...
FCStd node splitted:

"read node"
It can import from multiple files but I didn't find a way to populate a dropdown list of the parts to select, so I added a field to filter by name, just writing parts name separated by comma and no spaces ( split(',')... )

"write node" ( mesh/solid modes)
I still have to code multiple file writing in write node.
I tried to write a solid input from the "mesh to solid" node, it works!
The parts writed from blender are overwrited by name in the FCStd file.
The solid write mode support multiple solids and it will add an index on the base name, on changes it will delete all parts with base name before write them again. This system could be quite dangerous... It's just a way to experiment with blender/CAD workflow.

FCStd_nodes.zip

would it be here or where?

rastart · 2020-09-21T10:45:32Z

Yes, I think Exchange would be perfect

rastart · 2020-10-25T13:09:48Z

hello! I fixed some issues related to file array and filter by name( now use .label prop in freecad instead of .name... I noticed that if you rename something in freecad it changes only the label)

FCStd_nodes_25_10_2020.zip

vicdoval · 2020-10-25T18:03:13Z

@rastart wouldn't you like to make a pull request? (https://www.youtube.com/playlist?list=PLRqwX-V7Uu6ZF9C0YMKuns9sLDzK6zoiV)

nortikin · 2020-10-26T20:08:37Z

@rastart @vicdoval
agree, git / github is must-have skill.

rastart · 2020-10-26T20:52:41Z

Ok, I should have pull the request!

rastart · 2020-10-27T18:14:35Z

Hello, I'm evaluating a convenient method to pass filter labels to read node.
I added a string input and it works fine ( I scripted a node to pass a simple string )
There are already some nodes in Sverchok to pass simple text line? maybe also in list format? (like 'list input' in number cat)
I could also try to make a node with an enum function to generate a dropdown list to select like Portnov pointed:

For reading node, add "Read List" button, which would read list of objects from FreeCAD's file and populate a dropdown list (or a list with checkboxes, so that the user can select several objects)

but in huge assembly would be a mess. Have you some feedbacks about it?
maybe a variant of SvExecNodeMod?
"dynamic_strings: bpy.props.CollectionProperty(type=SvExecNodeDynaStringItem)"

portnov · 2020-10-27T18:58:04Z

class SvShowFcstdNamesOp(bpy.types.Operator):
    bl_idname = "node.sv_show_fcstd_names"
    bl_label = "Show contents"
    bl_options = {'INTERNAL', 'REGISTER'}
    bl_property = "option"

    def get_items(self, context): ...

    option : EnumProperty(items = get_items)
    idtree : StringProperty()
    idname : StringProperty()


    def execute(self, context):
        tree = bpy.data.node_groups[self.idtree]
        node = tree.nodes[self.idname]
        node.name_filter = self.option
        return {'FINISHED'}

    def invoke(self, context, event):
        context.space_data.cursor_location_from_region(event.mouse_region_x, event.mouse_region_y)
        wm = context.window_manager
        wm.invoke_search_popup(self)
        return {'FINISHED'}

...

def draw_buttons():
    wrapper_tracked_ui_draw_op(layout, SvShowFcstdNamesOp.bl_idname, icon=...)

This will show drop-down menu similar to one that appears by Alt-Space.

rastart · 2020-10-27T20:03:25Z

Meanwhile I made up this... works nice!

Thanx for the dropdown code, I'll try to implement it in the next days

rastart · 2020-10-30T20:10:34Z

This will show drop-down menu similar to one that appears by Alt-Space.
Working!

DuncanLithgow · 2020-11-22T10:27:37Z

I've referenced this discussion at https://wiki.osarch.org/index.php?title=Sverchok if anyone wants to expand the text that would be great. Or at least check that what I've written makes sense.

rastart · 2020-11-29T23:46:22Z

added read sketch node!
The sketch geometry is converted in polylines by freecad 'discretize' function and passed to verts/edge data.
Added a resample function with a parameter 'max_points' that set the max number of point in relation to the max length in the sketch geometry.

Until now I just tested the nodes with random operations and I didnt experiment critical issues, mainly write node need some attention to avoid recursive overloading if the same freecad file is involved in read/write operation.
From here I'm going to make some little design project to experiment in freecad/sverchok using what we have done until now,
I'm thinking about some simple design involving mechanical, procedural and some direct blender modeling features all togheter.

portnov · 2020-11-30T05:13:23Z

Can you output curves as sverchok.utils.curve.core.SvCurve instances? you probably will have to write special class for that, or maybe one of classes from sverchok.utils.curve.freecad will suffice.

rastart · 2020-12-10T21:12:41Z

Can you output curves as sverchok.utils.curve.core.SvCurve instances? you probably will have to write special class for that, or maybe one of classes from sverchok.utils.curve.freecad will suffice.

OK! sverchok.utils.curve.core.SvCurve instances worked to translate freecad line, circle and arc.
Still to translate conics to sv curves: maybe this won't be so easy...

rastart · 2020-12-11T18:12:41Z

spreadsheet node preview... read/write mode
https://youtu.be/9DJoRjS3kD8

rastart · 2020-12-30T12:20:23Z

I just updated the freecad exchange nodes.
Mainly:

READ NODE -> add some sort logic (ex. to read just the body final shape without import all features shape)
WRITE NODE -> no changes
SKETCH NODE -> it apply to the sketch geometry the transform matrix of the sketch placement and the parent body placement
SPREADSHEET NODE -> no changes

I don't think I'm going to add more features so If you have some reviews from now I'll work just on refactoring!
Let me know!

Meanwhile I'll keep making design experiments with these nodes...

rastart · 2021-01-30T16:50:02Z

Can you output curves as sverchok.utils.curve.core.SvCurve instances? you probably will have to write special class for that, or maybe one of classes from sverchok.utils.curve.freecad will suffice.

for curves other than segments and circles I manged like that:
freecad_sketch_curve.toNurbs() -> SvNurbsCurve.build( SvNurbsMaths.FREECAD, freecad_sketch_curve.Degree ecc...

It seems to work fine:

58911031 · 2021-02-27T10:45:41Z

freecad link disabled could you give me the link again please

nortikin · 2021-02-27T22:35:54Z

@58911031 https://disk.yandex.ru/d/NhCrTKi3nIgTXA

vicdoval added 3 commits June 28, 2020 14:39

Solid Nodes and Extra-Nodes

9118642

refactor fix

72c5424

Merge branch 'master' of https://github.com/nortikin/sverchok into so…

030311e

…lid_nodes

vicdoval added 3 commits June 28, 2020 21:26

Solid to Mesh Expanded with stardard mode and mefisto mode

5187da6

solid edges started

f9e9dcb

Solid Edges working

31a3d41

Solid Faces and Cone Node

6dffd45

Solid Torus and Fixes

800afd7

import/export and mesh_to_solid_refine

d4e1738

vicdoval added 3 commits July 6, 2020 11:14

change offset default

73de606

Details in docs

8660353

details on docs 2

6159d59

vicdoval merged commit 09574c9 into nortikin:master Jul 6, 2020

portnov added the Solids label Sep 1, 2020

Solid Nodes and Extra-Nodes #3377

Solid Nodes and Extra-Nodes #3377

Conversation

vicdoval commented Jun 28, 2020 • edited

zeffii commented Jun 28, 2020

portnov commented Jun 28, 2020

vicdoval commented Jun 28, 2020

vicdoval commented Jun 29, 2020

portnov commented Jun 29, 2020

vicdoval commented Jun 30, 2020

zeffii commented Jun 30, 2020 • edited

vicdoval commented Jun 30, 2020

vicdoval commented Jun 30, 2020 • edited

zeffii commented Jun 30, 2020

zeffii commented Jun 30, 2020 • edited

zeffii commented Jun 30, 2020

vicdoval commented Jun 30, 2020

zeffii commented Jun 30, 2020 • edited

vicdoval commented Jun 30, 2020

zeffii commented Jun 30, 2020

portnov commented Jun 30, 2020 • edited

portnov commented Jun 30, 2020

portnov commented Jun 30, 2020

portnov commented Jun 30, 2020

portnov commented Jun 30, 2020

portnov commented Jul 6, 2020

zeffii commented Jul 6, 2020

nortikin commented Jul 6, 2020

rastart commented Sep 13, 2020 • edited

portnov commented Sep 13, 2020 • edited

rastart commented Sep 20, 2020 • edited

nortikin commented Sep 21, 2020

rastart commented Sep 21, 2020

rastart commented Oct 25, 2020 • edited

vicdoval commented Oct 25, 2020

nortikin commented Oct 26, 2020

rastart commented Oct 26, 2020

rastart commented Oct 27, 2020 • edited

portnov commented Oct 27, 2020 • edited

rastart commented Oct 27, 2020 • edited

rastart commented Oct 30, 2020

DuncanLithgow commented Nov 22, 2020

rastart commented Nov 29, 2020 • edited

portnov commented Nov 30, 2020

rastart commented Dec 10, 2020 • edited

rastart commented Dec 11, 2020

rastart commented Dec 30, 2020 • edited

rastart commented Jan 30, 2021 • edited

58911031 commented Feb 27, 2021

nortikin commented Feb 27, 2021

vicdoval commented Jun 28, 2020 •

edited

zeffii commented Jun 30, 2020 •

edited

vicdoval commented Jun 30, 2020 •

edited

zeffii commented Jun 30, 2020 •

edited

zeffii commented Jun 30, 2020 •

edited

portnov commented Jun 30, 2020 •

edited

rastart commented Sep 13, 2020 •

edited

portnov commented Sep 13, 2020 •

edited

rastart commented Sep 20, 2020 •

edited

rastart commented Oct 25, 2020 •

edited

rastart commented Oct 27, 2020 •

edited

portnov commented Oct 27, 2020 •

edited

rastart commented Oct 27, 2020 •

edited

rastart commented Nov 29, 2020 •

edited

rastart commented Dec 10, 2020 •

edited

rastart commented Dec 30, 2020 •

edited

rastart commented Jan 30, 2021 •

edited