Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node groups UI #3624

Merged
merged 21 commits into from Oct 19, 2020
Merged

Node groups UI #3624

merged 21 commits into from Oct 19, 2020

Conversation

Durman
Copy link
Collaborator

@Durman Durman commented Oct 8, 2020

Addressed problem description

#3319
In this PR I'm going to add Group node and all functionality responsible for drawing its user interface. Adding group nodes is too big functionality I would be able to add it in one PR.

Preflight checklist

  • Add group menu
  • Add separate trees for groups
  • Handling sockets creation
  • Add tree description
  • Add group in and group out nodes into menu
  • Opertaor for creating group from selected nodes
  • Operator for ungrouping
  • Add the check if selection can be converted into a group
  • Take into account frames during grouping / ungrouping (rerouters ?)
  • Add import error
    _
  • Code changes complete.
  • Code documentation complete.
  • Manual testing done.
  • Ready for merge.

@Durman
Copy link
Collaborator Author

Durman commented Oct 8, 2020

description

@Durman
Copy link
Collaborator Author

Durman commented Oct 12, 2020

It turned out that coding grouping and ungrouping operators are harder than I thought. Even performance is the issue. I think main problem is array like structure of tree nodes and tree links. Also that straight references should not be keepped. I think I have to create module which will convert tree in more convenient data structure what make much easier manypulate with it.

@Durman
Copy link
Collaborator Author

Durman commented Oct 13, 2020

Funny thing is that most nodes have Node as first base class but in this case poll method does not work.

class VectorsOutNode(bpy.types.Node, SverchCustomTreeNode):

@Durman Durman merged commit 00f515e into master Oct 19, 2020
1 check passed
@Durman Durman deleted the node_groups_ui branch October 19, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant