Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update electron to the latest version 馃殌" #601

Merged
merged 1 commit into from Sep 30, 2018

Conversation

Projects
None yet
2 participants
@mhuggins
Copy link
Contributor

commented Sep 30, 2018

Reverts #556

See electron/electron#14883 for details on why this is being reverted.

@mhuggins mhuggins force-pushed the revert-556-greenkeeper/electron-3.0.0 branch from 96558fe to 3e61f69 Sep 30, 2018

@codecov

This comment has been minimized.

Copy link

commented Sep 30, 2018

Codecov Report

Merging #601 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
+ Coverage    57.21%   57.22%   +<.01%     
===========================================
  Files          191      191              
  Lines         1573     1571       -2     
  Branches       217      215       -2     
===========================================
- Hits           900      899       -1     
+ Misses         563      562       -1     
  Partials       110      110

@mhuggins mhuggins force-pushed the revert-556-greenkeeper/electron-3.0.0 branch from 3e61f69 to e446206 Sep 30, 2018

@mhuggins mhuggins merged commit 1fb8fbe into develop Sep 30, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 57.21%)
Details
codecov/project 57.22% (+<.01%) compared to 1e01261
Details
security/snyk - package.json (nos) No new issues
Details

@mhuggins mhuggins deleted the revert-556-greenkeeper/electron-3.0.0 branch Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.