New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not remove users from Access list #41

Closed
rg-artcom opened this Issue Sep 28, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@rg-artcom
Copy link

rg-artcom commented Sep 28, 2018

Hi, we have the following installation:
Ubuntu 18.04/Apache2/Passenger/Ruby 2.3.7/Redmine 3.4.6/Vault 0.3.9

If I want to remove a user from the access list I can save the result but if I go to edit the key again the old user list is shown in the access list.
In the logfile I can see:

Started PATCH "/projects/proj/keys/4" for 10.1.1.116 at 2018-09-28 14:19:22 +0200
Processing by KeysController#update as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"***", "vault_key"=>{"name"=>"testkey", "login"=>"login", "url"=>"https://", "type"=>"Vault::Password", "body"=>"foo", "tags"=>"bar", "comment"=>""}, "commit"=>"Save", "project_id"=>"proj", "id"=>"4"}
Current user: user (id=4)
WARNING: Can't mass-assign protected attributes for Vault::Password: tags
plugins/vault/app/controllers/keys_controller.rb:102:in block in update' plugins/vault/app/controllers/keys_controller.rb:98:in update'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

@noshutdown-ru-user

This comment has been minimized.

Copy link
Member

noshutdown-ru-user commented Sep 28, 2018

We will try to reproduce this case in our environment and let you know

@noshutdown-ru-user noshutdown-ru-user self-assigned this Sep 28, 2018

noshutdown-ru-user added a commit that referenced this issue Sep 30, 2018

@noshutdown-ru-user

This comment has been minimized.

Copy link
Member

noshutdown-ru-user commented Sep 30, 2018

@rg-artcom

This comment has been minimized.

Copy link

rg-artcom commented Oct 4, 2018

Ok, thank you. I tried this version and it looks like I can edit the list now.

@rg-artcom rg-artcom closed this Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment