Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep_disguise_on_attack detour is not supported on Windows #21

Closed
nosoop opened this issue Jun 13, 2020 · 1 comment
Closed

keep_disguise_on_attack detour is not supported on Windows #21

nosoop opened this issue Jun 13, 2020 · 1 comment
Labels
platform-specific This doesn't work on every platform

Comments

@nosoop
Copy link
Owner

nosoop commented Jun 13, 2020

Convert keep_disguise_on_attack to use virtual hooks (or write something that lets the game access that attribute class)

keep disguise on attack is currently only supported on Linux as it's easy to find a signature for it. This originally used a signature to avoid having to hook every weapon individually on spawn.

Windows doesn't provide a unique signature for this, so it needs to be migrated over.

@nosoop nosoop added the platform-specific This doesn't work on every platform label Jun 13, 2020
@nosoop nosoop changed the title Convert keep_disguise_on_attack to use virtual hooks keep_disguise_on_attack is not supported on Windows Jun 22, 2020
@nosoop nosoop changed the title keep_disguise_on_attack is not supported on Windows keep_disguise_on_attack detour is not supported on Windows Jun 22, 2020
@nosoop
Copy link
Owner Author

nosoop commented Feb 21, 2021

I think this will be superceded and removed in the near future; injecting the actual unused attribute into the runtime schema works and has the same effect.

(This would be the method implied by "writ[ing] something that lets the game access that attribute class".)

@nosoop nosoop closed this as completed in 4c2738c Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-specific This doesn't work on every platform
Projects
None yet
Development

No branches or pull requests

1 participant