Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tables.scss): add margin to table is-border class #133

Merged
merged 5 commits into from Dec 9, 2018
Merged

Conversation

BcRikko
Copy link
Member

@BcRikko BcRikko commented Dec 9, 2018

ref #100

margin: 4px; was missing 馃槺

table margin

before after
2018-12-09 10 05 10 2018-12-09 10 05 19

demo page

demo

@BcRikko BcRikko added the bug Something isn't working label Dec 9, 2018
@BcRikko BcRikko self-assigned this Dec 9, 2018
@BcRikko BcRikko changed the title [WIP]fix(tables.scss): add margin to table is-border class fix(tables.scss): add margin to table is-border class Dec 9, 2018
@BcRikko BcRikko requested a review from a team December 9, 2018 01:39
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdallahalsamman
Copy link
Member

abdallahalsamman commented Dec 9, 2018

@BcRikko can you fix the conflicts please?

If I fix them after I have approved the changes, I won't be able to merge 馃ぇ

@BcRikko
Copy link
Member Author

BcRikko commented Dec 9, 2018

@evexoio I resolved it 馃檹

Copy link
Member

@trezy trezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃帄

@trezy trezy merged commit 99011b1 into develop Dec 9, 2018
@BcRikko BcRikko deleted the table-margin branch December 11, 2018 10:50
@BcRikko
Copy link
Member Author

BcRikko commented Dec 18, 2018

馃帀 This PR is included in version 1.0.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants