Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storybook backgrounds #231

Merged
merged 3 commits into from Dec 27, 2018
Merged

Conversation

trezy
Copy link
Member

@trezy trezy commented Dec 27, 2018

Description
This adds the Storybook backgrounds addon to our Storybook setup. This is really useful because it allows users to flip through various colors to see what our components look like in different environments.

This PR does not introduce any breaking changes.

I've added the Storybook backgrounds addon which allows users viewing the storybook to change the
background behind components, which will make it easier to see how the main NES.css theme looks in
various contexts.
I've added the Storybook backgrounds addon which allows users viewing the storybook to change the
background behind components, which will make it easier to see how the main NES.css theme looks in
various contexts.
@trezy trezy added enhancement New feature or request documentation Adding, removing, or updating documentation labels Dec 27, 2018
@trezy trezy self-assigned this Dec 27, 2018
@trezy trezy requested a review from a team December 27, 2018 08:50
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdallahalsamman abdallahalsamman merged commit 3ab3cd5 into develop Dec 27, 2018
@abdallahalsamman abdallahalsamman deleted the feat/add-storybook-backgrounds branch December 27, 2018 09:04
@BcRikko
Copy link
Member

BcRikko commented Feb 16, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adding, removing, or updating documentation enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants