-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-64: Chess (Portable Game Notation) #1094
Conversation
Looks good. I would change the title to include Chess, like |
Is this what jester uses? If so, I have no objection to this. |
It's planned that jester publishes all games in the form that can be agreed upon here. Generally, jester will obey whatever we can come up with here. But keep in mind, that PGN is a notation for "finished" games and the NIP does not contain any references to actual game mechanics on purpose. |
Demo website is now live: https://jesterui.github.io/nip64/ Undrafting! 🎉 |
@vitorpamplona @staab Any feedback is highly appreciated. Is there anything I can do to assist the review process? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Please let me know if any more information or feedback is required. 🙏 |
⭐ 🚀 |
To merge, there is a need for 2v lients that implement this NIP |
Understood. Does the NIP website and JesterUI count as clients? |
Imo such niche NIP should become a NUD? The kind number could be marked on this repo as reserverd for the NUD. |
I know what you mean. As a background: I have been asked by @fiatjaf to provide a NIP for this some long time ago and only had time at the beginning of this year 🤦 . So maybe this is already obsolete, and I can quite understand the benefits and drawbacks of this being an own NIP. @fiatjaf Please excuse and forgive me for taking so long to be polished and finished. Do whatever feels best! |
I mean, this chess spec is great and all, but the NIP numbers will be capped at 99 or something I heard. One drawback of the NUD approach is there is no guarantee relays will keep the NUD article forever (or longer than github would keep a NIP around xD) |
I understand. It is not in my interest to occupy any magic numbers. (Chess has a wide audience and might spark interest for nostr – but this should not by any means be a justification for it to be an own NIP.) |
Thank you for writing this NIP @theborakompanioni. I'm for merging this. If for nothing else, because every decentralized protocol should be able to play chess (there is chess on ActivityPub and chess on SSB, for example), and the chess client was created in the early days of Nostr. Also chess is a very traditional and old game, surpassed only by Go and StarCraft. If I remember correctly there was another chess client at the time. But we can keep this open indefinitely and wait for another implementation. |
I have implemented to display the chess in Brostr, but to merge this PR, I think we need to implement a client that publishes PGN notes. |
But I can also add the ability to publish PGN events to the NIP-64 website in the meantime–would that be feasible? |
Sounds good, but I'm not sure it is feasible. @fiatjaf what do you think? |
I think we can merge it already. Should I? How can we view that game on Brostr? |
Sorry, the new version is not released yet, but will be very soon. |
62b44e6
to
5d37fea
Compare
Resolved conflicts and rebased onto current master (744bce8). 🙏 |
Nice! |
NIP-64
Reserving
kind := 64
for notes representing chess games in PGN format.NIP-64: https://github.com/theborakompanioni/nips/blob/nip-64/64.md
Website: https://jesterui.github.io/nip64/
(Former discussion: #212)