Skip to content

Instagram feeds#1551

Merged
pablof7z merged 6 commits intonostr-protocol:masterfrom
vitorpamplona:instagram
Nov 27, 2024
Merged

Instagram feeds#1551
pablof7z merged 6 commits intonostr-protocol:masterfrom
vitorpamplona:instagram

Conversation

@vitorpamplona
Copy link
Copy Markdown
Collaborator

@vitorpamplona vitorpamplona commented Oct 27, 2024

Adds a simple kind for picture-first clients building Instagram-like feeds, where the picture should be attenuated and the descriptions are less important and might not even be displayed in the main UI.

No, I don't think Kind 1s must be reused for these clients.

And no, NIP-94 became too generic for this.

Read here

@fiatjaf
Copy link
Copy Markdown
Member

fiatjaf commented Oct 28, 2024

Looks good at first glance.

@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

vitorpamplona commented Oct 28, 2024

I am starting to wonder if NIP-71's "vertical videos" is too broad. They should be short vertical videos. No one wants to see a movie in these feeds, not even vertical movies.

@sepehr-safari
Copy link
Copy Markdown
Contributor

NIPs like these are essential to move the ecosystem forward! Relying on a few broad NIPs just doesn't cover all advanced use cases. For example, with Pinstr, I had to create custom events that other clients don't recognize, which disrupts compatibility and limits potential growth for those kind of clients.

@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

@sepehr-safari which kinds do you use? Would you switch to the new kind here or should we just use your kind?

@derekross
Copy link
Copy Markdown

I'm a fan. Text only kind 1 events are clearly different.

@sepehr-safari
Copy link
Copy Markdown
Contributor

@sepehr-safari which kinds do you use?

Pinstr uses kind: 33889.

Would you switch to the new kind here or should we just use your kind?

I think none of the above! Pinstr needs more options than this NIP and it's not a replacement of Instagram.

@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

ohh I see, so a pinstr only shows boards and each board is basically a list of links that can be sorted in any way the user sees fit. Cool. Yeah, they are different.

@frbitten
Copy link
Copy Markdown
Contributor

Wouldn't it be simpler to have JSON data where there is the description and the imeta? After all, they are the content of the post. I think putting them in tags will complicate the parsing of this in the relay and in the clients.

@believethehype
Copy link
Copy Markdown
Contributor

I think it's great and would be a great addition to galleries, replacing their content with these.

@flox1an
Copy link
Copy Markdown

flox1an commented Oct 30, 2024

Tagging with a geo location might be good. NIP-52 uses:

// Location
    ["location", "<location>"],
    ["g", "<geohash>"],

The annotate-user in the list of imeta-fields looked a bit strange to me, but I guess we need it at that level.

Comment thread 68.md Outdated
vitorpamplona and others added 2 commits November 15, 2024 08:15
@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

@pablof7z i think you forgot the imeta tag: https://njump.me/nevent1qqsdnxzaw49t4h8h60zjmn6x6emvl2chayte4zj2m85cwkdr3jln4fcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsyg86np9a0kajstc8u9h846rmy6320wdepdeydfz8w8cv7kh9sqv02gpsgqqqqq2qtd56d4

If you put the imeta tags in as root tags we won't know which tag relates to which image.

@pablof7z
Copy link
Copy Markdown
Member

hmmm, strange, will investigate

@pablof7z
Copy link
Copy Markdown
Member

correct, I had a race condition

@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

@pablof7z
Copy link
Copy Markdown
Member

oh jesus, thank god, I thought it was all in one string and I was dying inside

@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

vitorpamplona commented Nov 19, 2024

vitorpamplona added a commit to vitorpamplona/amethyst that referenced this pull request Nov 19, 2024
@vitorpamplona
Copy link
Copy Markdown
Collaborator Author

Shipped on Amethyst v0.93+

Since we got Amethyst and Olas, can we merge this?

@arthurfranca
Copy link
Copy Markdown
Contributor

That's the law 'round these parts

@pablof7z pablof7z merged commit e4cc95e into nostr-protocol:master Nov 27, 2024
@fiatjaf
Copy link
Copy Markdown
Member

fiatjaf commented Nov 27, 2024

That's the law 'round these parts

That is not the law at all. It's not like two cowboys can come up with some stupid idea, implement it in two clients no one knows about, then merge it into the repo, that would be a nonsense policy destined to make the repository suck and be useless forever and just confuse everybody.

But in this case I believe it was good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants