New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Kick up unauthorized_client error #147

Merged
merged 3 commits into from Jun 14, 2018

Conversation

2 participants
@mindofbeholder
Contributor

mindofbeholder commented Jun 10, 2018

This will catch the "unauthorized_client" error that is seen when someone sets up their reddit application as a "web app" and attempts to authenticate with a username & password instead of a token.

closes not-an-aardvark/snoowrap#93

FEAT: Kick up unauthorized_client error
This will catch the "unauthorized_client" error that is seen when someone sets up their reddit application as a "web app" and attempts to authenticate with a username & password instead of a token.

closes not-an-aardvark/snoowrap#93
@mindofbeholder

This comment has been minimized.

Show comment
Hide comment
@mindofbeholder

mindofbeholder Jun 11, 2018

Contributor

Or we could just directly kick up the actual error message. I was just looking to make the message a touch more user friendly.

Contributor

mindofbeholder commented Jun 11, 2018

Or we could just directly kick up the actual error message. I was just looking to make the message a touch more user friendly.

@not-an-aardvark

This comment has been minimized.

Show comment
Hide comment
@not-an-aardvark

not-an-aardvark Jun 12, 2018

Owner

Hi, thanks for the pull request.

Would it work to add a check for any error property on a response object? That way, errors can be handled in general without needing to hardcode specific error messages.

Owner

not-an-aardvark commented Jun 12, 2018

Hi, thanks for the pull request.

Would it work to add a check for any error property on a response object? That way, errors can be handled in general without needing to hardcode specific error messages.

FEAT: Directly return error thrown by Reddit
If there is an error_description or error this will be kicked directly back up to the developer.
@mindofbeholder

This comment has been minimized.

Show comment
Hide comment
@mindofbeholder

mindofbeholder Jun 12, 2018

Contributor

This more along the lines of what you were thinking?

Contributor

mindofbeholder commented Jun 12, 2018

This more along the lines of what you were thinking?

@mindofbeholder

This comment has been minimized.

Show comment
Hide comment
@mindofbeholder

mindofbeholder Jun 13, 2018

Contributor

I wouldn't call it nitpicking. More like having standards. Not sure how I managed to phrase it in that way. Sorry about that.

Contributor

mindofbeholder commented Jun 13, 2018

I wouldn't call it nitpicking. More like having standards. Not sure how I managed to phrase it in that way. Sorry about that.

@not-an-aardvark

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit cd2cc85 into not-an-aardvark:master Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment