Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include non-workspace links. #60

Closed
Overload119 opened this issue Jun 8, 2021 · 5 comments
Closed

Do not include non-workspace links. #60

Overload119 opened this issue Jun 8, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@Overload119
Copy link

I have 2 workspaces, 1 work and 1 personal.

In the "work" workspace I accidentally opened a link in the Personal.
(This is a document called Session Log).

image

Now any time I search for Session Log it shows me the Personal one within the Work workspace.
This is a bit of a nuisance. I think it would be better to scope files searches within the Workspace you are currently on.

@astoilkov
Copy link
Member

Quick question. I thought of a way to improve the current behavior — move external files to the bottom of the search. This will be an improvement if your problem is that you accidentally open the wrong file. However, it won't be a solution if the cause is different. Can you share why you don't want files to appear?

Personally, I don't like the current behavior because some personal information may show up while showing something to a colleague at work for example.

@Overload119
Copy link
Author

I think it's clutter.
I don't see why I would want to view an external file from my workspace frequently - it defeats the point of the workspace. If I accidentally added a file, I think while it's open as a tab you can keep it searched otherwise it should not appear.

@Overload119
Copy link
Author

In my use case above I will never click on the one outside my workspace. It will always be there though and that's a waste of UI space.

There could be an option to "forget this file" but I feel it's not worth it.

@astoilkov
Copy link
Member

I've made external files not available in files popup and editor completions. It's possible we find a better solution in the future, but for now, we prefer to make it simpler by default.

Note that the same problem exists in the Workspaces popup where, if you open a workspace, you can never remove it.

@astoilkov astoilkov added the enhancement New feature or request label Jun 17, 2021
@astoilkov
Copy link
Member

We changed this behavior and now we don't include external files in the Files dialog.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants