DataMapper support #53

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

titanous commented Sep 4, 2010

I've implemented DataMapper support. I didn't do all of the caching implementation, because I wasn't clear on what the #outside_transaction method is needed for (it might be that I've been staring at the code for 3 hours straight, and it's past midnight ;).

There is one Machinable spec that doesn't pass when run with everything, but works fine when run the spec file is run separately. At this point I'm not sure where there is state leakage, but I'm not super familiar with your code yet.

I just transliterated the specs, and they seem to pass. I'll be writing a project using DM + Machinist tomorrow, so if I run into any problems I'll fix them.

Cheers,

Jonathan

Guys, do you plan to merge this changes?

This. It would be great to use the official Machinist repo again.

+1 on adding DataMapper support to machinist!

titanous closed this Jun 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment