Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing #13

Merged
merged 13 commits into from
Dec 14, 2017
Merged

Printing #13

merged 13 commits into from
Dec 14, 2017

Conversation

note
Copy link
Owner

@note note commented Dec 14, 2017

fixes #1 and probably to great extend #8

@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #13 into master will decrease coverage by 0.67%.
The diff coverage is 93.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   95.18%   94.51%   -0.68%     
==========================================
  Files          16       19       +3     
  Lines         291      328      +37     
  Branches       24       24              
==========================================
+ Hits          277      310      +33     
- Misses         14       18       +4
Impacted Files Coverage Δ
.../main/scala/net/michalsitko/xml/entities/AST.scala 0% <ø> (ø) ⬆️
.../scala/net/michalsitko/xml/syntax/ElementOps.scala 100% <ø> (ø) ⬆️
...net/michalsitko/xml/optics/XmlDocumentOptics.scala 100% <100%> (ø)
...in/scala/net/michalsitko/xml/syntax/document.scala 100% <100%> (ø)
...ala/net/michalsitko/xml/syntax/OpticsBuilder.scala 95.12% <100%> (ø) ⬆️
...la/net/michalsitko/xml/optics/XmlDocumentOps.scala 100% <100%> (ø)
.../scala/net/michalsitko/xml/parsing/XmlParser.scala 95.12% <91.66%> (+0.47%) ⬆️
...cala/net/michalsitko/xml/printing/XmlPrinter.scala 96.15% <92.3%> (-3.85%) ⬇️
...scala/net/michalsitko/xml/printing/XmlWriter.scala 94% <94.87%> (-3.96%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5cbca...939deed. Read the comment docs.

@note note merged commit 6f0320b into master Dec 14, 2017
@note note deleted the printing branch December 14, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XmlParser should read XML version and encoding
1 participant