Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hungarian (ANSI) translation from installer #1789

Closed
batagy opened this issue Apr 23, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@batagy
Copy link
Contributor

commented Apr 23, 2016

Hi!

The ANSI version of Hungarian translation is not maintaned from long time.
It's not needed.
Please remove the ANSI version of Hungarian translation from the installer.

Note: Obviously, please keep the normal UTF version of Hungarian translation in installer!

Thanks a lot
György

@batagy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2017

Hi!

This issue is still present in version 7.3.
The ANSI version of Hungarian translation should be removed.

Thanks
György

@cmeriaux

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2017

You should do a PR to remove the ANSI file.
I only see a UTF-8 file in the repository : PowerEditor\installer\nativeLang\hungarian.xml
Where is the ANSI one ?

@batagy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2017

Hi @cmeriaux ,

Thanks! It's strange. The ANSI version appear during the installation wizard, during step "Choose Components", under Custom option, under Localization. I think the installer somehow adds it always automatically from the normal UTF-8 file PowerEditor\installer\nativeLang\hungarian.xml, Somewhere it's hardcoced. But where?

@batagy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2017

Hi again,

At least the ANSI version is referred at this point in repo:
notepad-plus-plus/PowerEditor/installer/nsisInclude/langs.nsh

@SinghRajenM

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2017

Removed in PR #2954

@donho donho closed this in eaf8f8e Mar 5, 2017

SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this issue Mar 6, 2017

bahusoid added a commit to bahusoid/fork-notepad-plus-plus that referenced this issue Mar 20, 2017

MAPJe71 added a commit to MAPJe71/Notepad-Plus-Plus_Fork that referenced this issue Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.