Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking issues in recorded macro #1948

Open
VladLazarovici opened this issue Jun 11, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@VladLazarovici
Copy link

commented Jun 11, 2016

Have the following text:
This is a text is want to keep
This is a text is want to remove
This is a text is want to keep
This is a text is want to keep
This is a text is want to remove
This is a text is want to keep

I.
Start recording a macro.

  1. Go at the beginning of the text
  2. Go to Find and Replace, Mark tab, check Bookmark line option and enter text keep in Find what area
  3. Press Mark all (leave window open) -> lines 1,3,4,6 are marked
  4. Go to Search - Bookmark - Remove unmarked lines -> lines 2 and 5 are removed
  5. Press Clear all marks. -> all marks are cleared
  6. Close window and stop recording the macro.
    Restore the original text and run the macro.

Expected:
This is a text is want to keep appears on 4 lines, all of which are unmarked,

Actual:
This is a text is want to keep appears on 4 lines, all of which are marked

II.
Have the same text.
Start recording a macro.

  1. Go at the beginning of the text
  2. Go to Find and Replace, Mark tab, check Bookmark line option and enter text keep in Find what area
  3. Press Mark all (leave window open) -> lines 1,3,4,6 are marked
  4. Go to Search - Bookmark - Inverse bookmark -> lines 2 and 5 are marked, lines 1,3,4,6 are unmarked
  5. Go to Search - Bookmark - Remove bookmarked lines. -> Lines 2 and 5 are removed
  6. Press Clear all marks. -> all marks are cleared
  7. Close window and stop recording the macro.
    Restore the original text and run the macro.

Expected:
This is a text is want to keep appears on 4 lines, all of which are unmarked,

Actual:
This is a text is want to remove appears on 2 lines

System details: Intel i5 at 2.6 GHz, 4GB RAM, Windows 7 Ultimate 64 bit
Application version: Notepad++ v6.9.2

@sasumner

This comment has been minimized.

Copy link

commented Sep 26, 2018

Tested in version 7.5.8 on 26 September 2018. Still exists.

@VladLazarovici 's case I problem seems to originate from the "Clear all marks" button press action not being recorded into the macro. Indeed if you try to record ONLY that action in a macro, it results in Playback begin greyed out when you go to test it.

Case II adds the complication of inversing bookmarks. That action also appears to not be recorded into the macro. Again, if you try to record ONLY that action in a macro, it results in Playback begin greyed out when you go to test it.

@sasumner

This comment has been minimized.

Copy link

commented Sep 26, 2018

Followup on Case II: Even though you can't record the inverse-bookmarks command (value is 43050) into a macro, the action will work if you hand-edit shortcuts.xml and insert the following into an existing macro where you want the inversing of bookmarks to occur:

<Action type="2" message="0" wParam="43050" lParam="0" sParam="" />

@MetaChuh

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

please update your notepad++ to the latest version Notepad++ 7.6.6 and migrate or reinstall your plugins if you update from version 7.5.9 or below.
if your issue still persists, and it is still of relevance to you, please feel free to file a new issue as easy to understand and reproducible as possible.

thank you for your help and best regards.


general notes:

please close your issues as soon as you are satisfied, to help
keeping the notepad++ issue tracker clean.

when creating a new issue, please provide all information as shown at the issue template.
your notepad++ debug info is part of the minimum requirements.
(? > Debug Info... > Copy debug info into clipboard).

please also conduct a search at the issue tracker beforehand, to check if a similar issue
already exists.

for general questions, or if it is not sure, whether your issue is directly related to
the notepad++ source code, please visit us at the notepad++ community forum, and
search if related topics exists. you are welcome to post either at similar
topics, or to create a new topic at Help Wanted or General Discussion.
(no extra account is needed, just use your github account to sign in)

                        Click here to visit the Notepad++ Community Forum                         

@MetaChuh MetaChuh closed this Apr 23, 2019

@sasumner

This comment has been minimized.

Copy link

commented Apr 23, 2019

Reverified in Notepad++ 7.6.6. STILL EXISTS, both case I and case II.

@sasumner

This comment has been minimized.

Copy link

commented Jun 12, 2019

I retested in Notepad++ 7.7 32-bits and recording a "Clear All Bookmarks" into a macro works successfully when playing back the macro.

Restesting "Inverse Bookmark" in 7.7 results in it still not being recordable (as described above). :(

@sasumner

This comment has been minimized.

Copy link

commented Jun 12, 2019

Inverse-bookmarking is not macro-recordable is because IDM_SEARCH_INVERSEMARKS is missing from the if (_recordingMacro) big switch statement in NppCommands.cpp.

@MetaChuh MetaChuh reopened this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.