Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable save button after underlying file is changed externally #3246

Closed
suchko opened this Issue May 5, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@suchko
Copy link

commented May 5, 2017

Description of the Issue

When a file is in the editor and it is changed by an external program, npp recognizes this and asks if you want to reload the file. If you say no, it should enable the save button since the file is different than the one which is on the disk and is "dirty".

Steps to Reproduce the Issue

  1. Open a file
    1a Change the file
    1b Save the file
    1c Note that save button is disabled since file is not dirty
  2. Change the file with another editor
  3. Answer no when asked if you want to reload it

Expected Behavior

The save button should be enabled since file has changes which can be saved

Actual Behavior

Save button is not enabled and I must make and undo a change in order to save to disk

Debug Information

@Colombino

This comment has been minimized.

Copy link

commented May 18, 2017

I just hit that bug (and created account only to comment). It's much dangerous than it looks.
My use case was:

  1. Modified a file.
  2. Reverted the entire directory and said 'no' to the question to reload.
  3. Pressed Ctrl+S to overwrite this file only (I never click the button).
    It took me some time to figure out, that the file is not saved.
    When I closed the file (just to try, I had the change in the clipboard) it silently lost my changed buffer.

irgendsontyp added a commit to irgendsontyp/notepad-plus-plus that referenced this issue Jul 7, 2017

Fixes notepad-plus-plus#3246
Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++

@donho donho closed this in 7aef4a6 Jul 14, 2017

@tweimer tweimer marked this as a duplicate of #3527 Jul 15, 2017

MAPJe71 added a commit to MAPJe71/Notepad-Plus-Plus_Fork that referenced this issue Jul 19, 2017

Fix file not dirty while its content changed on the hard drive.
Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++.

Fixes notepad-plus-plus#3246, closes notepad-plus-plus#3499

AndresTraks added a commit to AndresTraks/notepad-plus-plus that referenced this issue Feb 17, 2018

Fix file not dirty while its content changed on the hard drive.
Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++.

Fixes notepad-plus-plus#3246, closes notepad-plus-plus#3499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.