Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for multi-line feature #3023

Closed
wants to merge 5 commits into from

Conversation

@AngryGamer
Copy link
Contributor

commented Mar 12, 2017

Changes:

  1. Text on tabs with multi-line are no longer clipped (g, y, etc).
  2. Fix tab switching hotkeys (shift+MW, ctrl+MW, shift+ctrl+MW)
  3. Hijack shift+MW hotkey to move tabs rather than switch to them (while drag and drop enabled)
  4. Fix drag and dropping tabs with multi-line enabled.

@AngryGamer AngryGamer changed the title Fix tab text being clipped while multi-line is enabled. Fixes for multi-line feature Mar 12, 2017

AngryGamer referenced this pull request Mar 12, 2017
@donho

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

Hi @AngryGamer Thank you for the patch.

Text on tabs with multi-line are no longer clipped (g, y, etc).

I have never seen text clipped. Could you provide the instructions to reproduce it?

Fix tab switching hotkeys (shift+MW, ctrl+MW, shift+ctrl+MW)

What do you mean by "MW" ?

Fix drag and dropping tabs with multi-line enabled.

This is good definitely!

@donho

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

@AngryGamer
Please do another PR which contains 4 commits for each enhancements.
It's just difficult to review your PR.

@donho donho self-assigned this Mar 18, 2017

@donho donho added the suspended label Mar 18, 2017

@donho
Copy link
Member

left a comment

Please do another PR which contains 4 commits for each enhancements, to make code review easier.

@bahusoid

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2017

@donho Text is clipped for active tab. I've already uploaded example here:
e1125f0#commitcomment-21159220

@AngryGamer

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2017

Hi @donho

Please do another PR which contains 4 commits for each enhancements.

The PR was updated to split changes into several commits.

I have never seen text clipped. Could you provide the instructions to reproduce it?

Enable reduce & multi-line with 2 rows of tabs. The active tab will have characters clipped (_, q, y, p, g, j, etc).

What do you mean by "MW" ?

MW = mousewheel

@donho
donho approved these changes Mar 19, 2017
@donho

This comment has been minimized.

Copy link
Member

commented Mar 19, 2017

@AngryGamer I just cannot open the branch of this PR in Github desktop.
Could you open an another PR and close this one?
Thank you.

@AngryGamer

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2017

OK, opened PR#3075

@AngryGamer AngryGamer closed this Mar 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.