Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3246 #3499

Conversation

Projects
None yet
5 participants
@irgendsontyp
Copy link
Contributor

irgendsontyp commented Jul 7, 2017

Fixes #3246.

Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++.

Fixes #3246
Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++
@@ -5011,7 +5011,12 @@ void Notepad_plus::notifyBufferChanged(Buffer * buffer, int mask)

// Then we ask user to update
if (doReloadOrNot(buffer->getFullPathName(), buffer->isDirty()) != IDYES)
{
// Since the file has but the user doesn't want to reload it, set state to dirty

This comment has been minimized.

Copy link
@justanotheranonymoususer

This comment has been minimized.

Copy link
@irgendsontyp

irgendsontyp Jul 7, 2017

Author Contributor

Thanks, I updated the comment! Guess I was not sure whether to say "the file has changed", "the file content has changed" or "the file has changed in the file system" or something else, so I might have decided to just omit the relevant parts of the sentence :)

@irgendsontyp

This comment has been minimized.

Copy link
Contributor Author

irgendsontyp commented Jul 12, 2017

I'm curious when this PR (and my other two ones) will get a review. I'm kinda new to GitHub and those were my first three pull requests at all, so I do not know how much time it takes normally until a PR gets reviewed/merged.

Does someone know?

@AngryGamer

This comment has been minimized.

Copy link
Contributor

AngryGamer commented Jul 13, 2017

@irgendsontyp it can take a while, @donho generally reviews the PRs all at once.

@donho donho self-assigned this Jul 14, 2017

@donho donho added the accepted label Jul 14, 2017

@donho donho added this to the 7.x (master) milestone Jul 14, 2017

@donho donho closed this in 7aef4a6 Jul 14, 2017

@vlakoff

This comment has been minimized.

Copy link
Contributor

vlakoff commented Jul 14, 2017

The kind of small change that greatly improves the workflow. Thanks :)

MAPJe71 added a commit to MAPJe71/Notepad-Plus-Plus_Fork that referenced this pull request Jul 19, 2017

Fix file not dirty while its content changed on the hard drive.
Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++.

Fixes notepad-plus-plus#3246, closes notepad-plus-plus#3499

AndresTraks added a commit to AndresTraks/notepad-plus-plus that referenced this pull request Feb 17, 2018

Fix file not dirty while its content changed on the hard drive.
Set buffer state to dirty when the file on the file system has changed but the user decided to not reload it in Notepad++.

Fixes notepad-plus-plus#3246, closes notepad-plus-plus#3499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.